ci: require a changeset when shippable src changes (GH #189 post-mortem)#192
Merged
Conversation
#188 merged a behavior fix (runFlow allowlist) to main with NO version bump, so it was undeliverable to marketplace installs and got re-reported as #189. Add a PR-only CI job that fails when scripts/cdp-bridge/src/ changes without a changeset — making the missing-bump class impossible rather than merely discouraged. - scripts/require-changeset.sh: the guard (seams: CHANGED_FILES, REPO_ROOT, BASE_REF) - scripts/test/require-changeset.test.sh: 4-case TDD regression test - ci.yml: PR-only require-changeset job + run the guard unit test in the build job Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A PR-only CI guard that fails when shippable MCP source (
scripts/cdp-bridge/src/) changes without a changeset.Why
Direct follow-up to the #189 / v0.44.45 post-mortem: #188 merged a real behavior fix (the
runFlowallowlist) tomainwith no version bump, so it never reached marketplace installs and was re-reported as #189. The fix existed — it was just undeliverable. This makes that class of mistake impossible rather than relying on remembering to bump.How
scripts/require-changeset.sh— diffs the PR vs base; if anyscripts/cdp-bridge/src/file changed, requires ≥1.changeset/*.md. Seams:CHANGED_FILES,REPO_ROOT,BASE_REF. Fails-open on infra errors (won't spuriously block).scripts/test/require-changeset.test.sh— 4-case TDD regression test (src+no-changeset → fail; src+changeset → pass; non-src → pass; empty → pass). Run in theBuild & Testjob.ci.yml— newrequire-changesetjob (PR-only).github.base_refis passed viaenv+ a quoted shell var (no${{ }}interpolation intorun:).Scope / notes
.claude-pluginmanifest (the manifest is the changeset output).cdp-bridge/src/, so it passes its own gate (verified locally againstmain).CHANGELOG.md(diverged from the changesets per-package logs) — flagged as separate cleanup.🤖 Generated with Claude Code