Skip to content

Commit 343ade4

Browse files
authored
Merge pull request LykosAI#1248 from ionite34/update-comfy-zluda-args
Fixed ComfyUI-Zluda not inheriting --enable-manager from the base ComfyUI launch options…
2 parents 5d4b468 + a6bad97 commit 343ade4

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
1616
- Fixed SwarmUI user settings (theme, output format, server configuration, etc.) and any user-added backend entries being overwritten when the install flow ran over an existing install — `Settings.fds` and `Backends.fds` are now merged with their existing contents instead of being rewritten from a stale template
1717
- Fixed pip requirements handling for environment-marker dependencies - thanks to @NeuralFault!
1818
- Fixed [#1608](https://github.com/LykosAI/StabilityMatrix/issues/1608) - Crash when cdn fetch fails due to error notification not being shown on UI Thread - thanks to @NeuralFault!
19+
- Fixed ComfyUI-Zluda inheriting `--enable-manager` from the base ComfyUI launch options, which blocked the bundled custom-node manager from initializing - thanks to @NeuralFault!
1920
### Supporters
2021
#### 🌟 Visionaries
2122
So much love to our Visionaries — **Waterclouds**, **bluepopsicle**, **Ibixat**, **Droolguy**, **snotty**, **LG**, and **whudunit** — thank you for your continued enthusiasm, kindness, and sheer staying-power. You've been with us through some big changes, and we're so lucky to have you in our corner. And the warmest welcome to our newest Visionaries **MrMxyzptlk12836**, **Psilocyfer18731**, **KalAbaddon**, **RustCupcake**, and **moon_milky2843** — we're so happy you're here, and we can't wait to get to know you. 💛
@@ -144,6 +145,7 @@ A massive thank you to our esteemed Visionaries: **Waterclouds**, **JungleDragon
144145
- Fixed SwarmUI user settings (theme, output format, server configuration, etc.) and any user-added backend entries being overwritten when the install flow ran over an existing install — `Settings.fds` and `Backends.fds` are now merged with their existing contents instead of being rewritten from a stale template
145146
- Fixed pip requirements handling for environment-marker dependencies - thanks to @NeuralFault!
146147
- Fixed [#1608](https://github.com/LykosAI/StabilityMatrix/issues/1608) - Crash when cdn fetch fails due to error notification not being shown on UI Thread - thanks to @NeuralFault!
148+
- Fixed ComfyUI-Zluda inheriting `--enable-manager` from the base ComfyUI launch options, which blocked the bundled custom-node manager from initializing - thanks to @NeuralFault!
147149
### Supporters
148150
#### 🌟 Visionaries
149151
Heaps of gratitude to our Visionaries — **Waterclouds**, **bluepopsicle**, **Ibixat**, **Droolguy**, **snotty**, **LG**, and **whudunit** — for sticking with us release after release. Your encouragement, your patience while we chase down those last bugs, and the sheer fact of you being here keeps us showing up at the keyboard. We're so glad you're part of this little corner of the internet with us. And big warm welcomes again to our newest Visionaries **MrMxyzptlk12836**, **Psilocyfer18731**, **KalAbaddon**, **RustCupcake**, and **moon_milky2843** — make yourselves at home, you're among friends! 💛

StabilityMatrix.Core/Models/Packages/ComfyZluda.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,11 @@ public override List<LaunchOptionDefinition> LaunchOptions
102102
},
103103
};
104104

105-
options.AddRange(base.LaunchOptions.Where(x => x.Name != "Cross Attention Method"));
105+
options.AddRange(
106+
base.LaunchOptions.Where(x =>
107+
x.Name != "Cross Attention Method" && !x.Options.Contains("--enable-manager")
108+
)
109+
);
106110
return options;
107111
}
108112
}

0 commit comments

Comments
 (0)