Skip to content

Commit e188a36

Browse files
mohnjilesclaude
andcommitted
Address PR review feedback: fix duplicate env var crash, mislabeled button, unused import
- Dedup env var keys via GroupBy before ToDictionary to prevent ArgumentException when duplicate enabled keys exist in UserEnvironmentVariablesList - Fix Add button in EnvVarsDialog incorrectly labeled as "Save" (Action_Save -> Action_New) - Remove unused System.Text.Json import from CivitDetailsPageViewModel Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c1969ee commit e188a36

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

StabilityMatrix.Avalonia/ViewModels/CheckpointBrowser/CivitDetailsPageViewModel.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
using System.ComponentModel.DataAnnotations;
44
using System.Globalization;
55
using System.Reactive.Linq;
6-
using System.Text.Json;
76
using AsyncAwaitBestPractices;
87
using Avalonia.Controls;
98
using Avalonia.Controls.Notifications;

StabilityMatrix.Avalonia/Views/Dialogs/EnvVarsDialog.axaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
Height="50"
6262
Command="{Binding AddRowCommand}"
6363
IconSource="Add"
64-
Label="{x:Static lang:Resources.Action_Save}" />
64+
Label="{x:Static lang:Resources.Action_New}" />
6565
<ui:CommandBarButton
6666
Width="45"
6767
Height="50"

StabilityMatrix.Core/Models/Settings/Settings.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ public IReadOnlyDictionary<string, string> EnvironmentVariables
170170
var userVars = UserEnvironmentVariablesList is { Count: > 0 }
171171
? UserEnvironmentVariablesList
172172
.Where(kvp => kvp.IsEnabled && !string.IsNullOrWhiteSpace(kvp.Key))
173-
.ToDictionary(kvp => kvp.Key, kvp => kvp.Value, StringComparer.Ordinal)
173+
.GroupBy(kvp => kvp.Key, StringComparer.Ordinal)
174+
.ToDictionary(g => g.Key, g => g.Last().Value, StringComparer.Ordinal)
174175
: UserEnvironmentVariables;
175176

176177
if (userVars is null || userVars.Count == 0)

0 commit comments

Comments
 (0)