Keep inline model dropdown alphabetical

Author: mohnjiles

StabilityMatrix.Avalonia/Controls/Inference/ModelCard.axaml

@@ -56,7 +56,7 @@
                                 Grid.Column="1"
                                 Padding="8,6,4,6"
                                 HorizontalAlignment="Stretch"
-                                ItemsSource="{Binding WorkflowFilteredModels}"
+                                ItemsSource="{Binding ClientManager.AllModels}"
                                 SelectedItem="{Binding SelectedUnifiedModel}"
                                 Theme="{StaticResource BetterComboBoxHybridModelTheme}" />
 

StabilityMatrix.Avalonia/ViewModels/Inference/ModelCardViewModel.cs

@@ -1,5 +1,4 @@
 using System.Collections.ObjectModel;
-using System.Collections.Specialized;
 using System.ComponentModel.DataAnnotations;
 using System.Text.Json.Nodes;
 using CommunityToolkit.Mvvm.ComponentModel;
@@ -185,7 +184,6 @@ public HybridModelFile? SelectedUnifiedModel
         nameof(ShowShift),
         nameof(ShowEncoderTypeSelection),
         nameof(HasRecommendedDefaults),
-        nameof(WorkflowFilteredModels),
         nameof(WorkflowProfileStatusText),
         nameof(ShowWorkflowProfileStatus),
         nameof(RecommendedDefaultsToolTip)
@@ -313,7 +311,6 @@ SelectedWorkflowProfile is InferenceWorkflowProfile.Auto
                 "Apply recommended sampler defaults: ER SDE / Simple / 30 steps / CFG 4",
             _ => "No recommended sampler defaults for this workflow",
         };
-    public IReadOnlyList<HybridModelFile> WorkflowFilteredModels => GetWorkflowFilteredModels();
 
     public event Action<InferenceWorkflowProfile>? RecommendedDefaultsRequested;
 
@@ -327,27 +324,19 @@ protected override void OnInitialLoaded()
         {
             SetDefaultEncoderCount();
         }
-
-        ClientManager.AllModels.CollectionChanged += AllModelsOnCollectionChanged;
     }
 
     public override void OnUnloaded()
     {
         base.OnUnloaded();
         ExtraNetworksStackCardViewModel.CardAdded -= ExtraNetworksStackCardViewModelOnCardAdded;
-        ClientManager.AllModels.CollectionChanged -= AllModelsOnCollectionChanged;
     }
 
     private void ExtraNetworksStackCardViewModelOnCardAdded(object? sender, LoadableViewModelBase e)
     {
         OnSelectedModelChanged(SelectedModel);
     }
 
-    private void AllModelsOnCollectionChanged(object? sender, NotifyCollectionChangedEventArgs e)
-    {
-        OnPropertyChanged(nameof(WorkflowFilteredModels));
-    }
-
     [RelayCommand]
     private static async Task OnConfigClickAsync()
     {
@@ -713,39 +702,6 @@ private static InferenceWorkflowProfile InferWorkflowProfile(HybridModelFile? mo
         return InferenceWorkflowProfile.DefaultCheckpoint;
     }
 
-    private IReadOnlyList<HybridModelFile> GetWorkflowFilteredModels()
-    {
-        var allModels = ClientManager.AllModels.ToList();
-
-        if (SelectedWorkflowProfile is InferenceWorkflowProfile.Auto or InferenceWorkflowProfile.Custom)
-            return allModels;
-
-        var compatibleModels = allModels
-            .Where(model => IsModelCompatibleWithWorkflow(model, SelectedWorkflowProfile))
-            .ToHashSet(HybridModelFile.Comparer);
-
-        if (compatibleModels.Count == 0)
-            return allModels;
-
-        return allModels
-            .OrderBy(model => compatibleModels.Contains(model) ? 0 : 1)
-            .ThenBy(model => model.ShortDisplayName, StringComparer.OrdinalIgnoreCase)
-            .ToList();
-    }
-
-    private static bool IsModelCompatibleWithWorkflow(HybridModelFile model, InferenceWorkflowProfile profile)
-    {
-        var isUnetModel = model.Local?.SharedFolderType is SharedFolderType.DiffusionModels;
-
-        if (profile is InferenceWorkflowProfile.DefaultCheckpoint)
-            return !isUnetModel;
-
-        if (!isUnetModel)
-            return false;
-
-        return InferWorkflowProfile(model, true) == profile;
-    }
-
     /// <summary>
     /// Loads text encoders from the saved model state, supporting both new and legacy formats.
     /// </summary>