Make python upgrade dialog more generic

Author: mohnjiles

StabilityMatrix.Avalonia/ViewModels/PackageManager/PackageCardViewModel.cs

@@ -442,7 +442,7 @@ public async Task Update()
             return;
         }
 
-        if (!await ShowForgeVenvRecreationDialogIfNeeded(basePackage, Package))
+        if (!await ShowPythonUpgradeDialogIfNeeded(basePackage, Package))
             return;
 
         var packageName = Package.DisplayName ?? Package.PackageName ?? "";
@@ -594,7 +594,7 @@ private async Task ChangeVersion()
             return;
         }
 
-        if (!await ShowForgeVenvRecreationDialogIfNeeded(basePackage, Package))
+        if (!await ShowPythonUpgradeDialogIfNeeded(basePackage, Package))
             return;
 
         var packageName = Package.DisplayName ?? Package.PackageName ?? "";
@@ -1031,32 +1031,32 @@ private async Task<bool> HasUpdate()
         }
     }
 
-    private static bool RequiresForgeVenvRecreationNotice(
+    private static bool RequiresPythonUpgradeNotice(
         BasePackage basePackage,
         InstalledPackage installedPackage
     )
     {
-        if (basePackage is not ForgeClassic)
+        if (basePackage.MinimumPythonVersion is not { } minimumVersion)
             return false;
 
         return PyVersion.TryParse(installedPackage.PythonVersion, out var currentVersion)
-            && currentVersion < PyInstallationManager.Python_3_13_12;
+            && currentVersion < minimumVersion;
     }
 
-    private async Task<bool> ShowForgeVenvRecreationDialogIfNeeded(
+    private async Task<bool> ShowPythonUpgradeDialogIfNeeded(
         BasePackage basePackage,
         InstalledPackage installedPackage
     )
     {
-        if (!RequiresForgeVenvRecreationNotice(basePackage, installedPackage))
+        if (!RequiresPythonUpgradeNotice(basePackage, installedPackage))
             return true;
 
         var dialog = new BetterContentDialog
         {
             Title = "Python Upgrade Required",
             Content =
                 "This update will recreate the package venv to migrate from Python "
-                + $"{installedPackage.PythonVersion} to {PyInstallationManager.Python_3_13_12}.\n\n"
+                + $"{installedPackage.PythonVersion} to {basePackage.MinimumPythonVersion}.\n\n"
                 + "Any custom pip packages manually installed into the current venv may need to be reinstalled. "
                 + "Your launch options, extensions, and generated files are not affected.\n\n"
                 + "You can also install a fresh copy and migrate manually.\n\n"

StabilityMatrix.Core/Models/Packages/BasePackage.cs

@@ -62,6 +62,12 @@ public abstract class BasePackage(ISettingsManager settingsManager)
     public virtual string? AdminRequiredReason => null;
     public virtual PyVersion RecommendedPythonVersion => PyInstallationManager.Python_3_10_17;
 
+    /// <summary>
+    /// Minimum Python version required for updates. When set, updating a package with a lower
+    /// installed Python version will prompt for venv recreation. Null means no minimum enforced.
+    /// </summary>
+    public virtual PyVersion? MinimumPythonVersion => null;
+
     /// <summary>
     /// Returns a list of extra commands that can be executed for this package.
     /// The function takes an InstalledPackage parameter to operate on a specific installation.

StabilityMatrix.Core/Models/Packages/ForgeClassic.cs

@@ -33,7 +33,7 @@ IPipWheelService pipWheelService
     private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
     private const string LegacyUpgradeAlert = "You are updating from an old version";
     private const string ContinuePrompt = "Press Enter to Continue";
-    private static readonly PyVersion MinimumPythonVersion = Python.PyInstallationManager.Python_3_13_12;
+    public override PyVersion? MinimumPythonVersion => Python.PyInstallationManager.Python_3_13_12;
 
     public override string Name => "forge-classic";
     public override string Author => "Haoming02";
@@ -198,7 +198,7 @@ public override async Task InstallPackage(
             );
 
         var shouldUpgradePython = options.IsUpdate && requestedPythonVersion < MinimumPythonVersion;
-        var targetPythonVersion = shouldUpgradePython ? MinimumPythonVersion : requestedPythonVersion;
+        var targetPythonVersion = shouldUpgradePython ? MinimumPythonVersion!.Value : requestedPythonVersion;
 
         if (shouldUpgradePython)
         {