Skip to content

Commit 533fbe8

Browse files
committed
fix: install requirements-global.txt for Windows ROCm path also
Was accidentally left in the original install path block and intended to apply for all install paths.
1 parent bdc2567 commit 533fbe8

1 file changed

Lines changed: 15 additions & 14 deletions

File tree

StabilityMatrix.Core/Models/Packages/OneTrainer.cs

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -140,23 +140,24 @@ await rocmPackageHelper
140140
};
141141

142142
await venvRunner.PipInstall(["-r", requirementsFileName], onConsoleOutput).ConfigureAwait(false);
143-
// Shared requirements-global.txt
144-
var requirementsGlobal = new FilePath(installLocation, "requirements-global.txt");
145-
var pipArgs = new PipInstallArgs().WithParsedFromRequirementsTxt(
146-
(await requirementsGlobal.ReadAllTextAsync(cancellationToken).ConfigureAwait(false)).Replace(
147-
"-e ",
148-
""
149-
),
150-
"scipy==1.15.1; sys_platform != 'win32'"
151-
);
143+
}
152144

153-
if (installedPackage.PipOverrides != null)
154-
{
155-
pipArgs = pipArgs.WithUserOverrides(installedPackage.PipOverrides);
156-
}
145+
// Shared requirements-global.txt (both paths)
146+
var requirementsGlobal = new FilePath(installLocation, "requirements-global.txt");
147+
var pipArgs = new PipInstallArgs().WithParsedFromRequirementsTxt(
148+
(await requirementsGlobal.ReadAllTextAsync(cancellationToken).ConfigureAwait(false)).Replace(
149+
"-e ",
150+
""
151+
),
152+
"scipy==1.15.1; sys_platform != 'win32'"
153+
);
157154

158-
await venvRunner.PipInstall(pipArgs, onConsoleOutput).ConfigureAwait(false);
155+
if (installedPackage.PipOverrides != null)
156+
{
157+
pipArgs = pipArgs.WithUserOverrides(installedPackage.PipOverrides);
159158
}
159+
160+
await venvRunner.PipInstall(pipArgs, onConsoleOutput).ConfigureAwait(false);
160161
}
161162

162163
public override async Task RunPackage(

0 commit comments

Comments
 (0)