refactor: pages declare their own docs target; filled help icon

Replaces per-page ? buttons in the package manager with a single one in the
shell header bound to the current page's DocsPath. Each page names its own help
target once, the shell renders exactly one button, and no surface can end up
with two — the console previously showed a stacked pair.

Also switches the icon to the filled variant for legibility at 16px, and drops
the redundant question-mark glyph from the inference Launch button, which sat
next to the docs button meaning something entirely different.

Co-Authored-By: Claude <noreply@anthropic.com>

Author: mohnjiles

StabilityMatrix.Avalonia/Styles/ControlThemes/DocsHelpButtonStyles.axaml

@@ -39,6 +39,7 @@
                         Height="16"
                         FontSize="16"
                         Foreground="{TemplateBinding Foreground}"
+                        IconVariant="Filled"
                         Symbol="QuestionCircle" />
                 </Border>
             </ControlTemplate>

StabilityMatrix.Avalonia/ViewModels/Base/PageViewModelBase.cs

@@ -19,4 +19,13 @@ public abstract class PageViewModelBase : DisposableViewModelBase
 
     public abstract string Title { get; }
     public abstract IconSource IconSource { get; }
+
+    /// <summary>
+    /// Documentation page this surface links to, as a
+    /// <see cref="Core.Models.Documentation.DocumentationPages"/> constant. A shell that hosts
+    /// pages renders this as a single help button in its header, so pages declare their own
+    /// help target instead of the shell guessing — and no surface ends up with two.
+    /// Null means this page has no contextual documentation.
+    /// </summary>
+    public virtual string? DocsPath => null;
 }

StabilityMatrix.Avalonia/ViewModels/PackageManager/MainPackageManagerViewModel.cs

@@ -18,6 +18,7 @@
 using StabilityMatrix.Core.Attributes;
 using StabilityMatrix.Core.Helper;
 using StabilityMatrix.Core.Models;
+using StabilityMatrix.Core.Models.Documentation;
 using StabilityMatrix.Core.Models.FileInterfaces;
 using StabilityMatrix.Core.Models.Packages;
 using StabilityMatrix.Core.Services;
@@ -46,6 +47,9 @@ public partial class MainPackageManagerViewModel : PageViewModelBase
     public override IconSource IconSource =>
         new SymbolIconSource { Symbol = Symbol.Box, IconVariant = IconVariant.Filled };
 
+    /// <inheritdoc />
+    public override string? DocsPath => DocumentationPages.SupportedPackages;
+
     /// <summary>
     /// List of installed packages
     /// </summary>

StabilityMatrix.Avalonia/ViewModels/PackageManager/PackageInstallDetailViewModel.cs

@@ -25,6 +25,7 @@
 using StabilityMatrix.Core.Helper.Factory;
 using StabilityMatrix.Core.Models;
 using StabilityMatrix.Core.Models.Database;
+using StabilityMatrix.Core.Models.Documentation;
 using StabilityMatrix.Core.Models.FileInterfaces;
 using StabilityMatrix.Core.Models.PackageModification;
 using StabilityMatrix.Core.Models.Packages;
@@ -52,6 +53,9 @@ IPyInstallationManager pyInstallationManager
     public override string Title { get; } = package.DisplayName;
     public override IconSource IconSource => new SymbolIconSource();
 
+    /// <inheritdoc />
+    public override string? DocsPath => DocumentationPages.InstallingPackages;
+
     public string FullInstallPath => Path.Combine(settingsManager.LibraryDir, "Packages", InstallName);
     public bool ShowReleaseMode => SelectedPackage.ShouldIgnoreReleases == false;
     public bool ShowBranchMode => SelectedPackage.ShouldIgnoreBranches == false;

StabilityMatrix.Avalonia/ViewModels/RunningPackageViewModel.cs

@@ -10,6 +10,7 @@
 using StabilityMatrix.Core.Attributes;
 using StabilityMatrix.Core.Helper;
 using StabilityMatrix.Core.Models;
+using StabilityMatrix.Core.Models.Documentation;
 using StabilityMatrix.Core.Models.Packages;
 using StabilityMatrix.Core.Processes;
 using StabilityMatrix.Core.Services;
@@ -33,6 +34,9 @@ public partial class RunningPackageViewModel : PageViewModelBase, IDisposable, I
     public override string Title => RunningPackage.InstalledPackage.DisplayName ?? "Running Package";
     public override IconSource IconSource => new SymbolIconSource();
 
+    /// <inheritdoc />
+    public override string? DocsPath => DocumentationPages.CommonIssues;
+
     [ObservableProperty]
     private bool autoScrollToEnd;
 

StabilityMatrix.Avalonia/Views/ConsoleOutputPage.axaml

@@ -73,13 +73,6 @@
             </ui:CommandBar.PrimaryCommands>
         </ui:CommandBar>
 
-        <controls:DocsHelpButton
-            Grid.Row="0"
-            Margin="0,0,16,4"
-            HorizontalAlignment="Right"
-            VerticalAlignment="Center"
-            DocsPath="{x:Static docs:DocumentationPages.CommonIssues}" />
-
         <avaloniaEdit:TextEditor
             x:Name="Console"
             Grid.Row="1"

StabilityMatrix.Avalonia/Views/InferencePage.axaml

@@ -182,13 +182,7 @@
                                 <Binding Path="!IsWaitingForConnection" />
                             </MultiBinding>
                         </Button.IsVisible>
-                        <StackPanel Orientation="Horizontal">
-                            <icons:Icon
-                                Margin="0,0,8,0"
-                                FontSize="14"
-                                Value="fa-solid fa-circle-question" />
-                            <TextBlock Text="{x:Static lang:Resources.Action_Launch}" />
-                        </StackPanel>
+                        <TextBlock Text="{x:Static lang:Resources.Action_Launch}" />
                     </Button>
 
                     <!--  Successful connection icon  -->

StabilityMatrix.Avalonia/Views/PackageManager/MainPackageManagerView.axaml

@@ -28,11 +28,6 @@
     </controls:UserControlBase.Resources>
 
     <Grid Margin="16" RowDefinitions="Auto,*,Auto">
-        <controls:DocsHelpButton
-            Grid.Row="0"
-            HorizontalAlignment="Right"
-            DocsPath="{x:Static docs:DocumentationPages.SupportedPackages}" />
-
         <ScrollViewer Grid.Row="1">
             <ui:ItemsRepeater x:Name="PackageCardsRepeater" ItemsSource="{Binding PackageCards}">
                 <ui:ItemsRepeater.Layout>

StabilityMatrix.Avalonia/Views/PackageManager/PackageInstallDetailView.axaml

@@ -46,7 +46,6 @@
                     IsVisible="{Binding SelectedPackage.LicenseUrl, Converter={x:Static StringConverters.IsNotNullOrEmpty}}"
                     NavigateUri="{Binding SelectedPackage.LicenseUrl}" />
                 <controls:HyperlinkIconButton Content="{x:Static lang:Resources.Action_OpenGithub}" NavigateUri="{Binding SelectedPackage.GithubUrl}" />
-                <controls:DocsHelpButton DocsPath="{x:Static docs:DocumentationPages.InstallingPackages}" />
             </StackPanel>
 
             <!--  Version Selector  -->

StabilityMatrix.Avalonia/Views/PackageManagerPage.axaml

@@ -29,22 +29,27 @@
         <!--  ReSharper restore Xaml.RedundantResource  -->
     </controls:UserControlBase.Resources>
 
-    <!--
-        No docs button on this shell: each page hosted in the frame below owns its own
-        contextual help, so a shell-level one would stack a second ? in the same corner.
-    -->
     <Grid RowDefinitions="Auto,*">
-        <ui:BreadcrumbBar
-            x:Name="BreadcrumbBar"
-            Grid.Row="0"
-            Margin="16,8"
-            ItemsSource="{Binding CurrentPagePath}">
-            <ui:BreadcrumbBar.ItemTemplate>
-                <DataTemplate x:DataType="base:PageViewModelBase">
-                    <ui:BreadcrumbBarItem Content="{Binding Title}" />
-                </DataTemplate>
-            </ui:BreadcrumbBar.ItemTemplate>
-        </ui:BreadcrumbBar>
+        <Grid Grid.Row="0" ColumnDefinitions="*,Auto">
+            <ui:BreadcrumbBar
+                x:Name="BreadcrumbBar"
+                Grid.Column="0"
+                Margin="16,8"
+                ItemsSource="{Binding CurrentPagePath}">
+                <ui:BreadcrumbBar.ItemTemplate>
+                    <DataTemplate x:DataType="base:PageViewModelBase">
+                        <ui:BreadcrumbBarItem Content="{Binding Title}" />
+                    </DataTemplate>
+                </ui:BreadcrumbBar.ItemTemplate>
+            </ui:BreadcrumbBar>
+
+            <!--  One button for the whole shell, targeting whichever page is showing.  -->
+            <controls:DocsHelpButton
+                Grid.Column="1"
+                Margin="0,8,16,8"
+                DocsPath="{Binding CurrentPage.DocsPath}"
+                IsVisible="{Binding CurrentPage.DocsPath, Converter={x:Static StringConverters.IsNotNullOrEmpty}}" />
+        </Grid>
 
         <controls1:Frame Name="FrameView" Grid.Row="1">
             <controls1:Frame.NavigationPageFactory>