-
-
Notifications
You must be signed in to change notification settings - Fork 563
v2.14.1 for real #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.14.1 for real #1263
Changes from all commits
eb43715
8560162
112a08d
86a66d8
eb0937b
93ca156
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -277,7 +277,7 @@ private bool ValidateUpdate(UpdateInfo? update) | |
| var appHash = Compat.AppVersion.Metadata; | ||
|
|
||
| // Always assume update if (We don't have hash && Update has hash) | ||
| if (string.IsNullOrEmpty(updateHash) && !string.IsNullOrEmpty(appHash)) | ||
| if (string.IsNullOrEmpty(appHash) && !string.IsNullOrEmpty(updateHash)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The change in this conditional statement is a crucial fix. The previous logic The new logic This correction ensures that if the local application build has no commit hash, but the update manifest specifies a version with a commit hash, the update is correctly identified as available. This is a significant improvement for update reliability. |
||
| { | ||
| return true; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new condition correctly handles the scenario where the currently installed application version might lack commit hash metadata (e.g., a local or older build), while the available update does include a hash.
By returning
truein this case (string.IsNullOrEmpty(appHash) && !string.IsNullOrEmpty(updateHash)), we ensure that users are prompted to update, which is a safer and more robust approach. This aligns well with the changelog entry: "Fixed updates to versions with commit hash version parts not being recognized when the current version has no commit hash part."Well done for catching this edge case!