Skip to content

Rocm Update to 7.2 index (Linux)#1594

Merged
mohnjiles merged 6 commits intoLykosAI:mainfrom
NeuralFault:rocm-update
Apr 9, 2026
Merged

Rocm Update to 7.2 index (Linux)#1594
mohnjiles merged 6 commits intoLykosAI:mainfrom
NeuralFault:rocm-update

Conversation

@NeuralFault
Copy link
Copy Markdown
Contributor

@NeuralFault NeuralFault commented Apr 8, 2026

  • ComfyUI
  • Forge/reForge
  • A1111 SD WebUI
  • InvokeAI (Not documented, tested working)

Also modernize the PyTorch install handling of A1111 SD WebUI to bring up to date to latest versions since default to dev branch for new installs. Switched Blackwell condition to IsLegacyNvidia (pre-Turing) to pin cu126 build (and its matching xformers). Removed MPS pinning as was very old.

NeuralFault and others added 2 commits April 8, 2026 01:41
 - ComfyUI
 - Forge/reForge
 - A1111 SD WebUI
 - InvokeAI (Not documented, tested working)

Modernize the PyTorch install handling to bring up to date to latest versions. Switched Blackwell condition to IsLegacyNvidia (pre-Turning) to pin cu126 build (and its matching xformers). Removed MPS pinning as was very old.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates ROCm indices to version 7.2 across multiple package models and refactors GPU detection logic in A3WebUI.cs, including the removal of Torch version pinning. Feedback identifies an unused variable, potential issues with xformers installation on modern NVIDIA GPUs due to logic changes, and inconsistent CUDA index selection between A3WebUI.cs and SDWebForge.cs.

NeuralFault and others added 4 commits April 8, 2026 01:51
Remove unused isRocm variable related to AMD GPU check.
Updated Torch and Torchvision version placeholders in the configuration.
Copy link
Copy Markdown
Contributor

@mohnjiles mohnjiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works on my machine 😄

@mohnjiles mohnjiles merged commit 90da7a8 into LykosAI:main Apr 9, 2026
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2026
@NeuralFault NeuralFault deleted the rocm-update branch April 9, 2026 03:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants