Add public function to check if geometry parameters are in range#42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a programmatic way to check whether ECCURT geometry parameters are within the interpolation dataset range, so callers (e.g., a web frontend) can avoid relying on parsing warnings emitted during curve evaluation.
Changes:
- Introduces a new public API function
ECCURT.is_in_model_range(d, vt, l, volume). - Refactors range-check warning logic in
eq_cap_line/eq_cap_pressures_newto call the shared helper. - Adds tests and documentation describing how to check parameter range.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/eq_cap_ECCURT.jl |
Adds is_in_model_range and reuses it for extrapolation warning checks. |
test/runtests.jl |
Adds basic tests for the new range-check API. |
docs/src/eqcap.md |
Documents the new helper for checking model parameter range. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me while working on a web frontend that it would be nice for the ECCURT to be able to programmatically check if parameters are in range without trying to capture from stdout or other hijinks.