Skip to content

Add public function to check if geometry parameters are in range#42

Merged
Ickaser merged 7 commits into
mainfrom
eccurt-range
Jul 13, 2026
Merged

Add public function to check if geometry parameters are in range#42
Ickaser merged 7 commits into
mainfrom
eccurt-range

Conversation

@Ickaser

@Ickaser Ickaser commented Jul 2, 2026

Copy link
Copy Markdown
Member

It occurred to me while working on a web frontend that it would be nice for the ECCURT to be able to programmatically check if parameters are in range without trying to capture from stdout or other hijinks.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a programmatic way to check whether ECCURT geometry parameters are within the interpolation dataset range, so callers (e.g., a web frontend) can avoid relying on parsing warnings emitted during curve evaluation.

Changes:

  • Introduces a new public API function ECCURT.is_in_model_range(d, vt, l, volume).
  • Refactors range-check warning logic in eq_cap_line / eq_cap_pressures_new to call the shared helper.
  • Adds tests and documentation describing how to check parameter range.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/eq_cap_ECCURT.jl Adds is_in_model_range and reuses it for extrapolation warning checks.
test/runtests.jl Adds basic tests for the new range-check API.
docs/src/eqcap.md Documents the new helper for checking model parameter range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/eq_cap_ECCURT.jl
Comment thread test/runtests.jl
@sodhadrashti03

Copy link
Copy Markdown
  1. It took me a while to figure out the line equation from the code. The equation can be added while explaining the close translation.
  2. The specific ranges for the input parameters (D), (vt), (L), and (V) can be mentioned.
  3. The legend for the last plot is a bit confusing and feels too generalized.
  4. It can be mentioned that the results are less reliable outside the original CFD geometry range.
  5. A practical example can be added showing when the equipment capability limit might be exceeded.

@Ickaser Ickaser merged commit 25993d1 into main Jul 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants