Skip to content

Commit 383efcd

Browse files
htejuningomolnar
authored andcommitted
sched: Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s
try_to_wake_up_local() should only be invoked to wake up another task in the same runqueue and BUG_ON()s are used to enforce the rule. Missing try_to_wake_up_local() can stall workqueue execution but such stalls are likely to be finite either by another work item being queued or the one blocked getting unblocked. There's no reason to trigger BUG while holding rq lock crashing the whole system. Convert BUG_ON()s in try_to_wake_up_local() to WARN_ON_ONCE()s. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Steven Rostedt <rostedt@goodmis.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/20130318192234.GD3042@htj.dyndns.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 7f6575f commit 383efcd

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

kernel/sched/core.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1488,8 +1488,10 @@ static void try_to_wake_up_local(struct task_struct *p)
14881488
{
14891489
struct rq *rq = task_rq(p);
14901490

1491-
BUG_ON(rq != this_rq());
1492-
BUG_ON(p == current);
1491+
if (WARN_ON_ONCE(rq != this_rq()) ||
1492+
WARN_ON_ONCE(p == current))
1493+
return;
1494+
14931495
lockdep_assert_held(&rq->lock);
14941496

14951497
if (!raw_spin_trylock(&p->pi_lock)) {

0 commit comments

Comments
 (0)