Add support for compressed streaming archives#844
Open
dinhngtu wants to merge 1 commit into
Open
Conversation
Member
|
I think I should introduce some changes before I merge this PR, because I want to reduce some dependencies on 7-Zip mainline definitions. For example, we should try to use NanaZip.Specification/NanaZip.Specification.SevenZip.h, we should improve if this lacks some definitions. Kenji Mouri |
dinhngtu
force-pushed
the
compressedtar
branch
2 times, most recently
from
1ede22c to
e6e4ba1
Compare
Add 5 new handlers CompressedTar, AutoDeb, AutoDebUncompressed, AutoRpm, AutoRpmUncompressed for decompression of the associated file formats. All 5 are based on the CompressedStreamArchive handler base and should respect K7 mitigation policies. CompressedStreamArchive works by caching all inner archive metadata on open, decompressing the inner archive on-the-fly and merging some inner/ outer props via GetArchiveProperty. Handlers configure CompressedStreamArchive by passing a CompressedStreamArchiveInfo struct containing outer and inner CArcInfo. Handlers can pick which member in the outer archive to extract (e.g. AutoDeb selects the 2nd member to get the data.tar instead of control.tar). CompressedStreamArchiveInfo is discovered from within g_Arcs via calling the new function LookupArchiveInfo on CLSIDs provided in CoreExports.hpp. Due to this current dependency on NanaZip.Core internals, the handlers and handler base are all hosted in NanaZip.Core. Add two new handler flags kCompositeArc and kLongExtension to deal with the new handlers. Particularly, kCompositeArc is needed to bypass these handlers in Open Inside * mode. kLongExtension doesn't seem to really matter but was included for completeness. Signed-off-by: Tu Dinh <contact@tudinh.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 5 new handlers CompressedTar, AutoDeb, AutoDebUncompressed, AutoRpm, AutoRpmUncompressed for decompression of the associated file formats.
All 5 are based on the CompressedStreamArchive handler base and should respect K7 mitigation policies.
CompressedStreamArchive works by caching all inner archive metadata on open, decompressing the inner archive on-the-fly and merging some inner/outer props via GetArchiveProperty. Handlers configure CompressedStreamArchive by passing a CompressedStreamArchiveInfo struct containing outer and inner CArcInfo. Handlers can pick which member in the outer archive to extract (e.g. DEB selects the 2nd member to get the data.tar instead of control.tar)
CompressedStreamArchiveInfo is discovered from within g_Arcs via calling the new function LookupArchiveInfo on CLSIDs provided in CoreExports.hpp. Due to this current dependency on NanaZip.Core internals, the handlers and handler base are all hosted in NanaZip.Core.
Add two new handler flags kCompositeArc and kLongExtension to deal with the new handlers. Particularly, kCompositeArc is needed to bypass these handlers in Open Inside * mode. kLongExtension doesn't seem to really matter but was included for completeness.
Known issues: open progress and open cancelling are not implemented, since CompressedStreamArchive does not monitor the opener progress (to simplify the code; see "Fix CompressedTar management of inner handler" for the removal of the progress monitor)
Tests: https://github.com/M2Team/K7Tests/tree/compressedtar (to be merged after this PR)