Split out platform independent converter logic for BooleanToString value converter

Author: jamesmcroft

src/MADE.Data.Converters/BooleanToStringValueConverter.Windows.cs

@@ -5,16 +5,15 @@
 namespace MADE.Data.Converters
 {
     using System;
-    using MADE.Data.Converters.Exceptions;
     using MADE.Data.Converters.Strings;
     using Windows.UI.Xaml;
     using Windows.UI.Xaml.Data;
 
     /// <summary>
     /// Defines a Windows components for a XAML value converter from <see cref="bool"/> to <see cref="string"/>.
     /// </summary>
-    [Obsolete("Use the replicated BooleanToStringValueConverter type from the MADE.UI.Data.Converters library instead.")]
-    public class BooleanToStringValueConverter : DependencyObject, IValueConverter, IValueConverter<bool, string>
+    [Obsolete("BooleanToStringValueConverter for Windows will be removed in a future major release. Use the replicated BooleanToStringValueConverter type from the MADE.UI.Data.Converters library instead.")]
+    public partial class BooleanToStringValueConverter : DependencyObject, IValueConverter, IValueConverter<bool, string>
     {
         /// <summary>
         /// Defines the dependency property for <see cref="TrueValue"/>.
@@ -88,50 +87,6 @@ public object ConvertBack(object value, Type targetType, object parameter, strin
 
             return this.ConvertBack(b, parameter);
         }
-
-        /// <summary>
-        /// Converts the <paramref name="value">value</paramref> to the <see cref="string"/> type.
-        /// </summary>
-        /// <param name="value">
-        /// The value to convert.
-        /// </param>
-        /// <param name="parameter">
-        /// The optional parameter used to help with conversion.
-        /// </param>
-        /// <returns>
-        /// The converted <see cref="string"/> object.
-        /// </returns>
-        public string Convert(bool value, object parameter = default)
-        {
-            return value ? this.TrueValue : this.FalseValue;
-        }
-
-        /// <summary>
-        /// Converts the <paramref name="value">value</paramref> back to the <see cref="bool"/> type.
-        /// </summary>
-        /// <param name="value">
-        /// The value to convert.
-        /// </param>
-        /// <param name="parameter">
-        /// The optional parameter used to help with conversion.
-        /// </param>
-        /// <returns>
-        /// The converted <see cref="bool"/> object.
-        /// </returns>
-        public bool ConvertBack(string value, object parameter = default)
-        {
-            if (value == this.TrueValue)
-            {
-                return true;
-            }
-
-            if (value == this.FalseValue)
-            {
-                return false;
-            }
-
-            throw new InvalidDataConversionException(nameof(BooleanToStringValueConverter), value, $"The value to convert back is not of the expected {nameof(this.TrueValue)} or {nameof(this.FalseValue)}");
-        }
     }
 }
 #endif

src/MADE.Data.Converters/BooleanToStringValueConverter.cs

@@ -0,0 +1,66 @@
+namespace MADE.Data.Converters
+{
+    using MADE.Data.Converters.Exceptions;
+
+    /// <summary>
+    /// Defines a value converter from <see cref="bool"/> to <see cref="string"/> with a pre-determined <see cref="TrueValue"/> and <see cref="FalseValue"/>.
+    /// </summary>
+    public partial class BooleanToStringValueConverter : IValueConverter<bool, string>
+    {
+#if !WINDOWS_UWP
+        /// <summary>
+        /// Gets or sets the positive/true value.
+        /// </summary>
+        public string TrueValue { get; set; }
+
+        /// <summary>
+        /// Gets or sets the negative/false value.
+        /// </summary>
+        public string FalseValue { get; set; }
+#endif
+
+        /// <summary>
+        /// Converts the <paramref name="value">value</paramref> to the <see cref="string"/> type.
+        /// </summary>
+        /// <param name="value">
+        /// The value to convert.
+        /// </param>
+        /// <param name="parameter">
+        /// The optional parameter used to help with conversion.
+        /// </param>
+        /// <returns>
+        /// The converted <see cref="string"/> object.
+        /// </returns>
+        public string Convert(bool value, object parameter = default)
+        {
+            return value ? this.TrueValue : this.FalseValue;
+        }
+
+        /// <summary>
+        /// Converts the <paramref name="value">value</paramref> back to the <see cref="bool"/> type.
+        /// </summary>
+        /// <param name="value">
+        /// The value to convert.
+        /// </param>
+        /// <param name="parameter">
+        /// The optional parameter used to help with conversion.
+        /// </param>
+        /// <returns>
+        /// The converted <see cref="bool"/> object.
+        /// </returns>
+        public bool ConvertBack(string value, object parameter = default)
+        {
+            if (value == this.TrueValue)
+            {
+                return true;
+            }
+
+            if (value == this.FalseValue)
+            {
+                return false;
+            }
+
+            throw new InvalidDataConversionException(nameof(BooleanToStringValueConverter), value, $"The value to convert back is not of the expected {nameof(this.TrueValue)} or {nameof(this.FalseValue)}");
+        }
+    }
+}

src/MADE.Data.Converters/DateTimeToStringValueConverter.Windows.cs

@@ -10,7 +10,7 @@ namespace MADE.Data.Converters
     /// <summary>
     /// Defines a Windows components for a XAML value converter from <see cref="DateTime"/> to <see cref="string"/> with an optional format string.
     /// </summary>
-    [Obsolete("Use the replicated DateTimeToStringValueConverter type from the MADE.UI.Data.Converters library instead.")]
+    [Obsolete("DateTimeToStringValueConverter for Windows will be removed in a future major release. Use the replicated DateTimeToStringValueConverter type from the MADE.UI.Data.Converters library instead.")]
     public partial class DateTimeToStringValueConverter : IValueConverter
     {
         /// <summary>