PR for fundamental core structure changes#51
Merged
Merged
Conversation
…rageFileEventListener as obsolete. Also added additional extra methods for EventLogger to support passing exceptions.
…ated for minimum target support.
…olete attribute. Updated MvvmLight library to use .NET Standard variant
jamesmcroft
requested review from
Tarc94 and
tom-made
and removed request for
Tarc94
Tarc94
requested changes
Mar 14, 2019
…form specific locators.
Tarc94
previously approved these changes
Mar 14, 2019
Tarc94
left a comment
Tarc94
left a comment
There was a problem hiding this comment.
This looks good to me, can't see any issues.
tom-made
requested changes
Mar 14, 2019
tom-made
left a comment
tom-made
left a comment
Contributor
There was a problem hiding this comment.
Some changes need to be made here and added some questions.
tom-made
approved these changes
Mar 14, 2019
tom-made
left a comment
tom-made
left a comment
Contributor
There was a problem hiding this comment.
Good for these to be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes made
This PR contains fundamental changes to the MADE App Components libraries which are described below.
Changes to minimum target version
Changes have been made to target the lowest minimum target version of .NET Standard and UWP so that the libraries can be installed with more projects.
This change sees the .NET Standard version lower from 2.0 to 1.4 and the UWP version to cover all versions instead of Fall Creators Update+
Changes to incorporate XPlat
Other changes associated with this PR include adding support for XPlat where MADE was using custom built alternatives. These changes have been kept to a minimum but as a co-owner of the project, I suggest that we start incorporating XPlat as the base API layer for building controls and other functions in MADE.
Some examples include:
MADE has a helper class for UI action dispatching which uses native APIs. XPlat contains a CoreDispatcher which does the same thing so has been replaced with it for consistency.
MADE has a color, thickness and orientation class. XPlat contains alternatives which are cross-platform and have been replaced where used.
Changes to NuGet package references
All package references have been updated to the latest versions.
The UWP libraries have been downgraded to a supported version (6.1.9).
Included as part of this change has been to replace the older PCL variant of MvvmLight with the .NET Standard version. This will have a breaking change on users who are currently using this as the CommonServiceLocator is no longer used which is described here: http://www.mvvmlight.net/std10
There currently is an issue outstanding in the MvvmLight project that users who are implementing Android functionality and use the MvvmLight android support extension cannot use this. There is an active PR for this (lbugnion/mvvmlight#25) but has been open since March last year.
There is also an open PR from myself with MvvmLight regarding Android support packages references (lbugnion/mvvmlight#60) with a PR (lbugnion/mvvmlight#61) which have not yet been resolved.
@tom-made would it be wise if we forked MvvmLight and created our own internal packages to resolve these issues?
What issues are associated?
No associated issues