Skip to content

Commit ead3daa

Browse files
committed
mstd compile definitions fixes
1 parent 32db155 commit ead3daa

3 files changed

Lines changed: 13 additions & 9 deletions

File tree

cmake/pcre2cppConfig.cmake.in

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,16 @@ foreach(comp ${@PROJECT_NAME@_FIND_COMPONENTS})
6060
elseif(comp STREQUAL "UTF32")
6161
target_compile_definitions(${comp_target} INTERFACE PCRE2CPP_DISABLE_UTF32)
6262
elseif(comp STREQUAL "CXX20")
63-
target_compile_definitions(${comp_target} INTERFACE PCRE2CPP_ENABLE_CXX20 MSTD_ENABLE_CXX20)
63+
target_compile_definitions(${comp_target} INTERFACE PCRE2CPP_ENABLE_CXX20
64+
MSTD_ENABLE_CXX20
65+
)
6466
set_target_properties(${comp_target} PROPERTIES
6567
INTERFACE_COMPILE_FEATURES cxx_std_20
6668
)
6769
elseif(comp STREQUAL "NO_ASSERT_ON_RELEASE")
68-
target_compile_definitions(${comp_target} INTERFACE PCRE2CPP_DISABLE_ASSERT_ON_RELEASE MSTD_DISABLE_ASSERT_ON_RELEASE)
70+
target_compile_definitions(${comp_target} INTERFACE PCRE2CPP_DISABLE_ASSERT_ON_RELEASE
71+
MSTD_DISABLE_ASSERT_ON_RELEASE
72+
)
6973
elseif(comp STREQUAL "EXCEPTIONS")
7074
set_target_properties(${comp_target} PROPERTIES
7175
INTERFACE_COMPILE_DEFINITIONS PCRE2CPP_CHANGE_ASSERTS_TO_EXCEPTIONS

cmake/third_party.cmake

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,7 @@ endif()
5656

5757
# MSTD
5858
if (DOWNLOAD_MSTD)
59-
CPMAddPackage(
60-
URI "gh:maipa01/mstd#v1.5.2"
61-
OPTIONS "MSTD_ENABLE_CXX20 ${PCRE2CPP_ENABLE_CXX20}"
62-
"MSTD_DISABLE_ASSERT_ON_RELEASE ${PCRE2CPP_DISABLE_ASSERT_ON_RELEASE}"
63-
)
59+
CPMAddPackage("gh:maipa01/mstd#v1.5.2")
6460
endif()
6561

6662
# GTEST

pcre2cpp/CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,13 @@ target_include_directories(${PROJECT_NAME} SYSTEM INTERFACE $<BUILD_INTERFACE:${
7979

8080
# region COMPILE_DEFINITIONS
8181
target_compile_definitions(${PROJECT_NAME} INTERFACE $<BUILD_INTERFACE:
82-
$<$<BOOL:${PCRE2CPP_ENABLE_CXX20}>:PCRE2CPP_ENABLE_CXX20>
82+
$<$<BOOL:${PCRE2CPP_ENABLE_CXX20}>: PCRE2CPP_ENABLE_CXX20
83+
MSTD_ENABLE_CXX20
84+
>
8385
$<$<BOOL:${PCRE2CPP_CHANGE_ASSERTS_TO_EXCEPTIONS}>:PCRE2CPP_CHANGE_ASSERTS_TO_EXCEPTIONS>
84-
$<$<BOOL:${PCRE2CPP_DISABLE_ASSERT_ON_RELEASE}>:PCRE2CPP_DISABLE_ASSERT_ON_RELEASE>
86+
$<$<BOOL:${PCRE2CPP_DISABLE_ASSERT_ON_RELEASE}>:PCRE2CPP_DISABLE_ASSERT_ON_RELEASE
87+
MSTD_DISABLE_ASSERT_ON_RELEASE
88+
>
8589
$<$<BOOL:${PCRE2CPP_DISABLE_UTF8}>:PCRE2CPP_DISABLE_UTF8>
8690
$<$<BOOL:${PCRE2CPP_DISABLE_UTF16}>:PCRE2CPP_DISABLE_UTF16>
8791
$<$<BOOL:${PCRE2CPP_DISABLE_UTF32}>:PCRE2CPP_DISABLE_UTF32>

0 commit comments

Comments
 (0)