Removed dependency to Microsoft.VisualStudio.ProjectSystem from the VisualStudioHelperService

Author: Irame

SmartCmdArgs/SmartCmdArgs.Shared/Helper/CpsProjectSupport.cs

@@ -8,6 +8,17 @@
 using System.Linq;
 using System.Threading.Tasks.Dataflow;
 
+// This isolation of Microsoft.VisualStudio.ProjectSystem dependencies into one file ensures compatibility
+// across various Visual Studio installations. This is crucial because not all Visual Studio workloads
+// include the ManagedProjectSystem extension by default. For instance, installing Visual Studio with only
+// the C++ workload does not install this extension, whereas it's included with the .NET workload at
+// "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\Extensions\Microsoft\ManagedProjectSystem".
+// One might consider adding the Microsoft.VisualStudio.ProjectSystem assembly to the VSIX. However, this approach fails due to
+// Visual Studio's configuration file (located at "%userprofile%\AppData\Local\Microsoft\VisualStudio\17.0_xxxxxxxx\devenv.exe.config")
+// specifying a binding redirect for Microsoft.VisualStudio.ProjectSystem.Managed to the latest version.
+// As such, ensuring compatibility requires knowledge of the version Visual Studio redirects to, which varies
+// by Visual Studio installation version.
+
 namespace SmartCmdArgs.Helper
 {
     public static class CpsProjectSupport
@@ -64,7 +75,7 @@ public static IEnumerable<string> GetLaunchProfileNames(EnvDTE.Project project)
             return null;
         }
 
-        public static IDisposable ListenToLaunchProfileChanges(EnvDTE.Project project, Action<ILaunchSettings> listener)
+        public static IDisposable ListenToLaunchProfileChanges(EnvDTE.Project project, Action listener)
         {
             if (TryGetProjectServices(project, out IUnconfiguredProjectServices unconfiguredProjectServices, out IProjectServices projectServices))
             {
@@ -74,7 +85,7 @@ public static IDisposable ListenToLaunchProfileChanges(EnvDTE.Project project, A
                     return null;
 
                 return launchSettingsProvider.SourceBlock.LinkTo(
-                    new ActionBlock<ILaunchSettings>(listener),
+                    new ActionBlock<ILaunchSettings>(_ => listener()),
                     new DataflowLinkOptions { PropagateCompletion = true });
             }
 

SmartCmdArgs/SmartCmdArgs.Shared/Services/VisualStudioHelperService.cs

@@ -1,6 +1,5 @@
 using EnvDTE;
 using Microsoft.VisualStudio;
-using Microsoft.VisualStudio.ProjectSystem.Debug;
 using Microsoft.VisualStudio.Shell;
 using Microsoft.VisualStudio.Shell.Interop;
 using SmartCmdArgs.Helper;
@@ -123,7 +122,7 @@ class ProjectState : IDisposable
 
             private IDisposable _launchSettingsChangeListenerDisposable;
 
-            public ProjectState(IVsHierarchyWrapper pHierarchy, Action<ILaunchSettings> launchProfileChangeAction)
+            public ProjectState(IVsHierarchyWrapper pHierarchy, Action launchProfileChangeAction)
             {
                 ProjectDir = pHierarchy.GetProjectDir();
                 ProjectName = pHierarchy.GetName();
@@ -188,7 +187,7 @@ private void AddProjectState(IVsHierarchyWrapper pHierarchy)
         {
             Guid projectGuid = pHierarchy.GetGuid();
             ProjectStateMap.GetValueOrDefault(projectGuid)?.Dispose();
-            ProjectStateMap[projectGuid] = new ProjectState(pHierarchy, profile =>
+            ProjectStateMap[projectGuid] = new ProjectState(pHierarchy, () =>
             {
                 ThreadHelper.JoinableTaskFactory.Run(async () =>
                 {