Skip to content

Commit 2ace1dc

Browse files
committed
ci: fix patched-JAR workflow + stdio-smoke test path
Three failures from the first CI run on the patched-JAR pipeline plus a stale path fix that should have ridden along originally: * NFRT requires `--dist <client|server|joined>` on the `run` subcommand; add `--dist joined` so all three NeoForge matrix jobs can produce a merged client+server patched JAR. * The Forge fixture's `settings.gradle` declared `rootProject.name` before the `pluginManagement {}` block, which Gradle rejects with "pluginManagement must appear before any other statements." Reorder so plugin management resolves first. * `__tests__/manual/mcp/stdio-server-smoke.test.ts` imported helpers from `../helpers/` and `../test-constants.js`, but those files live one directory higher (`__tests__/helpers/` and `__tests__/test-constants.ts`). Fix the relative paths so the smoke test can actually load.
1 parent a04b8cd commit 2ace1dc

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/patched-jars.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ jobs:
9191
OUT="$(pwd)/nfrt-out/${{ matrix.name }}.jar"
9292
if [ ! -f "$OUT" ]; then
9393
java -jar tools/nfrt.jar run \
94+
--dist joined \
9495
--neoforge "net.neoforged:neoforge:${{ matrix.neoforge }}:userdev" \
9596
--write-result "compiledWithNeoForge:$OUT"
9697
fi
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
rootProject.name = 'mc-dev-mcp-forge-fixture'
2-
31
pluginManagement {
42
repositories {
53
gradlePluginPortal()
64
maven { url = 'https://maven.minecraftforge.net/' }
75
}
86
}
7+
8+
rootProject.name = 'mc-dev-mcp-forge-fixture'

__tests__/manual/mcp/stdio-server-smoke.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { afterAll, beforeAll, describe, expect, it } from 'vitest';
2-
import { type McpTestSession, createMcpSession, extractFirstText } from '../helpers/mcp-stdio.js';
3-
import { TEST_MAPPING, TEST_VERSION, UNOBFUSCATED_TEST_VERSION } from '../test-constants.js';
2+
import { type McpTestSession, createMcpSession, extractFirstText } from '../../helpers/mcp-stdio.js';
3+
import { TEST_MAPPING, TEST_VERSION, UNOBFUSCATED_TEST_VERSION } from '../../test-constants.js';
44

55
/**
66
* True MCP transport E2E tests.

0 commit comments

Comments
 (0)