core: pre-commit

Author: simonprovost

CODE_OF_CONDUCT.md

@@ -131,4 +131,3 @@ For answers to common questions about this code of conduct, see the FAQ at
 [Mozilla CoC]: https://github.com/mozilla/diversity
 [FAQ]: https://www.contributor-covenant.org/faq
 [translations]: https://www.contributor-covenant.org/translations
-

README.md

@@ -4,7 +4,7 @@
     MCPStack
     <br>
   </h1>
-  <h4 align="center">Stack & Orchestrate MCP Tools — The Scikit-Learn Way, For LLMs</h4>
+  <h4 align="center">Stack & Orchestrate MCP Tools — The Scikit-Learn-Pipeline Way, For LLMs</h4>
 </div>
 
 <div align="center">
@@ -30,29 +30,29 @@
 
 ## <a id="about-the-project"></a>💡 About The Project
 
-`MCPStack` is a **`Scikit-Learn-Like` Pipeline orchestrator** for Model Context Protocols (MCPs).  
-It allows you to **stack multiple MCP tools together** into a pipeline of interest and expose them directly 
+`MCPStack` is a **`Scikit-Learn-Like` Pipeline orchestrator** for Model Context Protocols (MCPs).
+It allows you to **stack multiple MCP tools together** into a pipeline of interest and expose them directly
 into your favourite LLM environment, such as **Claude Desktop**.
 
 Think of it as **`scikit-learn` pipelines, but for Large Language Models**:
-* In `scikit-learn`, you chain `preprocessors`, `transformers`, and `estimators`.  
+* In `scikit-learn`, you chain `preprocessors`, `transformers`, and `estimators`.
 * In `MCPStack`, you chain MCP tools of interest. If some tools are not of interest, you simply do not include them in the pipeline.
 
 The LLM cannot use a tool that is not included in the pipeline.  This makes orchestration both **powerful** and **secure**.
 This permits sophisticated compositions in which the LLM can only access the tools you specify – no more, no less.
 
 **Wait, what is a Model Context Protocol (MCP) — In layman's terms ?**
 
-The Model Context Protocol (MCP) standardises interactions with machine learning (Large Language) models, 
-enabling tools and libraries to communicate successfully with a uniform workflow. 
+The Model Context Protocol (MCP) standardises interactions with machine learning (Large Language) models,
+enabling tools and libraries to communicate successfully with a uniform workflow.
 
 ---
 
 ## Installation
 
 > [!NOTE]
-> MCPStack is the orchestrator — it comes with core utilities and validated tools.  
-> All validated tools are listed under `mcp_tools` in the `pyproject.toml` and are auto-registered via  
+> MCPStack is the orchestrator — it comes with core utilities and validated tools.
+> All validated tools are listed under `mcp_tools` in the `pyproject.toml` and are auto-registered via
 > `[project.entry-points."mcpstack.tools"]`.
 
 ### Clone the repository
@@ -92,7 +92,7 @@ pre-commit install
 
 ## 🖥️ CLI Workflow
 
-You can manage and run your MCP pipelines directly from the CLI with the `mcpstack` command.  
+You can manage and run your MCP pipelines directly from the CLI with the `mcpstack` command.
 Every command is run with `uv run mcpstack` (or just `mcpstack` if installed globally).
 
 <img src="assets/readme/help.png" width="61.8%" align="left" style="border-radius: 10px;"/>
@@ -226,7 +226,7 @@ More chaining methods are available, such as `with_config(...)` to configure the
 
 You can also create your own MCP tool with the [`mcpstack-tool-builder` CLI](https://github.com/MCP-Pipeline/MCPStack-Tool-Builder), which will generate a skeleton for you to fill in.
 
-That means, creating the `actions` your MCP tool will allow LLMs to perform, and a `CLI` to 
+That means, creating the `actions` your MCP tool will allow LLMs to perform, and a `CLI` to
 initialise it, configure it, and run it. More in the documentation.
 
 <br clear="left">

SECURITY.md

@@ -13,18 +13,18 @@ Include the following information in your report:
 - **Description**: A clear explanation of the vulnerability, with reproduction steps if possible.
 - **Environment**: Operating system, Python version, MCP client, and any relevant setup details.
 
-Send reports to: **simon.gilbert.provost@gmail.com** 
+Send reports to: **simon.gilbert.provost@gmail.com**
 
 We will acknowledge receipt within 7 days and aim to provide a resolution or mitigation timeline within 30 days. Please do not share vulnerabilities publicly until a fix has been released.
 
 ## Scope and Considerations
 
-- **Tool Combinations**: MCPStack is designed to compose with other MCP tools. Unexpected or unsafe interactions between tools cannot be predicted or prevented at the MCPStack-Tool level. The responsibility for safe orchestration rests with the user.  
-- **Data Breach Risks**: MCPStack runs locally and does not send data to external services. There are no cloud communications by default, so conventional remote data breaches do not apply.  
+- **Tool Combinations**: MCPStack is designed to compose with other MCP tools. Unexpected or unsafe interactions between tools cannot be predicted or prevented at the MCPStack-Tool level. The responsibility for safe orchestration rests with the user.
+- **Data Breach Risks**: MCPStack runs locally and does not send data to external services. There are no cloud communications by default, so conventional remote data breaches do not apply.
 - **GitHub Issues and Pull Requests**: Do not upload sensitive data (such as private datasets, logs, or credentials) when filing issues or submitting pull requests. Use synthetic or anonymized examples instead.
 
 ## Good Practices
 
-- Keep dependencies updated.  
-- Test tool compositions in a controlled environment.  
-- Sanitize any shared examples when discussing issues publicly.
+- Keep dependencies updated.
+- Test tool compositions in a controlled environment.
+- Sanitize any shared examples when discussing issues publicly.

tests/core/test_config.py

@@ -1,6 +1,6 @@
 import os
 from pathlib import Path
-from unittest.mock import MagicMock, patch
+from unittest.mock import patch
 
 import pytest
 
@@ -68,11 +68,17 @@ def test_get_env_var_raise_if_missing(self):
 
     def test_validate_for_tools_success(self):
         """Test validate_for_tools method success."""
+
         class Tool(BaseTool):
-            def actions(self): return []
-            def to_dict(self): return {}
+            def actions(self):
+                return []
+
+            def to_dict(self):
+                return {}
+
             @classmethod
-            def from_dict(cls, params): return cls()
+            def from_dict(cls, params):
+                return cls()
 
         mock_tool = Tool()
         mock_tool.__class__.__name__ = "TestTool"
@@ -82,11 +88,17 @@ def from_dict(cls, params): return cls()
 
     def test_validate_for_tools_error(self):
         """Test validate_for_tools raises on error."""
+
         class Tool(BaseTool):
-            def actions(self): return []
-            def to_dict(self): return {}
+            def actions(self):
+                return []
+
+            def to_dict(self):
+                return {}
+
             @classmethod
-            def from_dict(cls, params): return cls()
+            def from_dict(cls, params):
+                return cls()
 
         mock_tool = Tool()
         mock_tool.__class__.__name__ = "TestTool"

tests/core/test_mcp_config_generator.py

@@ -4,11 +4,15 @@
 
 import pytest
 
-from MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config import ClaudeConfigGenerator
-from MCPStack.core.mcp_config_generator.mcp_config_generators.fast_mcp_config import FastMCPConfigGenerator
+from MCPStack.core.config import StackConfig
+from MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config import (
+    ClaudeConfigGenerator,
+)
+from MCPStack.core.mcp_config_generator.mcp_config_generators.fast_mcp_config import (
+    FastMCPConfigGenerator,
+)
 from MCPStack.core.utils.exceptions import MCPStackValidationError
 from MCPStack.stack import MCPStackCore
-from MCPStack.core.config import StackConfig
 
 
 @pytest.fixture
@@ -23,8 +27,16 @@ class TestClaudeConfigGenerator:
 
     @patch("shutil.which", return_value="/usr/bin/python")
     @patch("os.path.isdir", return_value=True)
-    @patch("MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config.ClaudeConfigGenerator._get_claude_config_path")
-    def test_generate_with_defaults(self, mock_get_path: MagicMock, mock_isdir: MagicMock, mock_which: MagicMock, mock_stack: MCPStackCore) -> None:
+    @patch(
+        "MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config.ClaudeConfigGenerator._get_claude_config_path"
+    )
+    def test_generate_with_defaults(
+        self,
+        mock_get_path: MagicMock,
+        mock_isdir: MagicMock,
+        mock_which: MagicMock,
+        mock_stack: MCPStackCore,
+    ) -> None:
         """Test generating config with defaults."""
         mock_get_path.return_value = None
         config = ClaudeConfigGenerator.generate(mock_stack)
@@ -38,23 +50,38 @@ def test_generate_with_defaults(self, mock_get_path: MagicMock, mock_isdir: Magi
         assert "TEST_ENV" in server["env"]
 
     @patch("shutil.which", return_value=None)
-    def test_invalid_command_raises_error(self, mock_which: MagicMock, mock_stack: MCPStackCore) -> None:
+    def test_invalid_command_raises_error(
+        self, mock_which: MagicMock, mock_stack: MCPStackCore
+    ) -> None:
         """Test invalid command raises error."""
         with pytest.raises(MCPStackValidationError, match="Invalid command"):
             ClaudeConfigGenerator.generate(mock_stack, command="/invalid/python")
 
     @patch("os.path.isdir", return_value=False)
-    def test_invalid_cwd_raises_error(self, mock_isdir: MagicMock, mock_stack: MCPStackCore) -> None:
+    def test_invalid_cwd_raises_error(
+        self, mock_isdir: MagicMock, mock_stack: MCPStackCore
+    ) -> None:
         """Test invalid cwd raises error."""
         with pytest.raises(MCPStackValidationError, match="Invalid cwd"):
             ClaudeConfigGenerator.generate(mock_stack, cwd="/invalid/dir")
 
     @patch("builtins.open", new_callable=mock_open)
     @patch("json.load")
     @patch("json.dump")
-    @patch("MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config.ClaudeConfigGenerator._get_claude_config_path")
+    @patch(
+        "MCPStack.core.mcp_config_generator.mcp_config_generators.claude_mcp_config.ClaudeConfigGenerator._get_claude_config_path"
+    )
     @patch("pathlib.Path.exists")
-    def test_merge_with_existing_config(self, mock_exists: MagicMock, mock_get_path: MagicMock, mock_dump: MagicMock, mock_load: MagicMock, mock_open_file: MagicMock, mock_stack: MCPStackCore, tmp_path: Path) -> None:
+    def test_merge_with_existing_config(
+        self,
+        mock_exists: MagicMock,
+        mock_get_path: MagicMock,
+        mock_dump: MagicMock,
+        mock_load: MagicMock,
+        mock_open_file: MagicMock,
+        mock_stack: MCPStackCore,
+        tmp_path: Path,
+    ) -> None:
         """Test merging with existing Claude config."""
         mock_path = tmp_path / "claude_config.json"
         mock_get_path.return_value = mock_path
@@ -68,7 +95,13 @@ def test_merge_with_existing_config(self, mock_exists: MagicMock, mock_get_path:
 
     @patch("builtins.open", new_callable=mock_open)
     @patch("json.dump")
-    def test_save_to_custom_path(self, mock_dump: MagicMock, mock_open_file: MagicMock, mock_stack: MCPStackCore, tmp_path: Path) -> None:
+    def test_save_to_custom_path(
+        self,
+        mock_dump: MagicMock,
+        mock_open_file: MagicMock,
+        mock_stack: MCPStackCore,
+        tmp_path: Path,
+    ) -> None:
         """Test saving to custom path."""
         save_path = tmp_path / "custom.json"
         config = ClaudeConfigGenerator.generate(mock_stack, save_path=str(save_path))
@@ -80,7 +113,9 @@ class TestFastMCPConfigGenerator:
 
     @patch("shutil.which", return_value="/usr/bin/python")
     @patch("os.path.isdir", return_value=True)
-    def test_generate_with_defaults(self, mock_isdir: MagicMock, mock_which: MagicMock, mock_stack: MCPStackCore) -> None:
+    def test_generate_with_defaults(
+        self, mock_isdir: MagicMock, mock_which: MagicMock, mock_stack: MCPStackCore
+    ) -> None:
         """Test generating config with defaults."""
         config = FastMCPConfigGenerator.generate(mock_stack)
         assert isinstance(config, dict)
@@ -93,20 +128,30 @@ def test_generate_with_defaults(self, mock_isdir: MagicMock, mock_which: MagicMo
         assert "TEST_ENV" in server["env"]
 
     @patch("shutil.which", return_value=None)
-    def test_invalid_command_raises_error(self, mock_which: MagicMock, mock_stack: MCPStackCore) -> None:
+    def test_invalid_command_raises_error(
+        self, mock_which: MagicMock, mock_stack: MCPStackCore
+    ) -> None:
         """Test invalid command raises error."""
         with pytest.raises(MCPStackValidationError, match="Invalid command"):
             FastMCPConfigGenerator.generate(mock_stack, command="/invalid/python")
 
     @patch("os.path.isdir", return_value=False)
-    def test_invalid_cwd_raises_error(self, mock_isdir: MagicMock, mock_stack: MCPStackCore) -> None:
+    def test_invalid_cwd_raises_error(
+        self, mock_isdir: MagicMock, mock_stack: MCPStackCore
+    ) -> None:
         """Test invalid cwd raises error."""
         with pytest.raises(MCPStackValidationError, match="Invalid cwd"):
             FastMCPConfigGenerator.generate(mock_stack, cwd="/invalid/dir")
 
     @patch("builtins.open", new_callable=mock_open)
     @patch("json.dump")
-    def test_save_to_custom_path(self, mock_dump: MagicMock, mock_open_file: MagicMock, mock_stack: MCPStackCore, tmp_path: Path) -> None:
+    def test_save_to_custom_path(
+        self,
+        mock_dump: MagicMock,
+        mock_open_file: MagicMock,
+        mock_stack: MCPStackCore,
+        tmp_path: Path,
+    ) -> None:
         """Test saving to custom path."""
         save_path = tmp_path / "custom.json"
         config = FastMCPConfigGenerator.generate(mock_stack, save_path=str(save_path))

tests/core/test_server.py

@@ -13,6 +13,7 @@ class TestMCPServer:
     def test_server_can_be_imported_as_module(self) -> None:
         """Test that the server can be imported as a module."""
         import MCPStack.core.server
+
         assert hasattr(MCPStack.core.server, "main")
         assert callable(MCPStack.core.server.main)
 
@@ -23,6 +24,7 @@ def test_main_success(self, mock_load: Mock) -> None:
         mock_stack = Mock(spec=MCPStackCore)
         mock_load.return_value = mock_stack
         from MCPStack.core.server import main
+
         main()
         mock_load.assert_called_once_with("test_config.json")
         mock_stack.build.assert_called_once()
@@ -32,7 +34,10 @@ def test_main_success(self, mock_load: Mock) -> None:
     def test_main_no_config_path(self) -> None:
         """Test main raises error when MCPSTACK_CONFIG_PATH is not set."""
         from MCPStack.core.server import main
-        with pytest.raises(MCPStackValidationError, match="MCPSTACK_CONFIG_PATH env var not set"):
+
+        with pytest.raises(
+            MCPStackValidationError, match="MCPSTACK_CONFIG_PATH env var not set"
+        ):
             main()
 
     @patch.dict(os.environ, {"MCPSTACK_CONFIG_PATH": "invalid.json"})
@@ -41,6 +46,7 @@ def test_main_load_failure(self, mock_load: Mock) -> None:
         """Test main handles load failure."""
         mock_load.side_effect = FileNotFoundError("Config not found")
         from MCPStack.core.server import main
+
         with pytest.raises(FileNotFoundError):
             main()
 
@@ -49,9 +55,11 @@ def test_main_load_failure(self, mock_load: Mock) -> None:
     def test_main_build_failure(self, mock_load: Mock) -> None:
         """Test main handles build failure."""
         from MCPStack.core.utils.exceptions import MCPStackValidationError
+
         mock_stack = Mock(spec=MCPStackCore)
         mock_load.return_value = mock_stack
         mock_stack.build.side_effect = MCPStackValidationError("Build failed")
         from MCPStack.core.server import main
+
         with pytest.raises(MCPStackValidationError):
             main()