Skip to content

type issues when building sdk #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ignaciojimenezr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

type issues when building sdk #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions sdk/src/oauth-login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ export async function runOAuthLogin(
oauthConformanceChecks: false,
});
let state = cloneEmptyFlowState();
let redirectUrl = config.redirectUrl;
let interactiveSession: InteractiveAuthorizationSession | undefined;

const updateState = (updates: Partial<OAuthFlowState>) => {
Expand All @@ -311,7 +310,7 @@ export async function runOAuthLogin(
});
}

redirectUrl =
const redirectUrl =
interactiveSession?.redirectUrl ??
config.redirectUrl ??
(deps.createDefaultRedirectUrl ?? createDefaultRedirectUrl)();
Expand Down Expand Up @@ -358,7 +357,7 @@ export async function runOAuthLogin(
serverUrl: config.serverUrl,
serverName: config.serverName,
redirectUrl,
requestExecutor: (request) => trackedRequest(request),
requestExecutor: (request: OAuthHttpRequest) => trackedRequest(request),
loadPreregisteredCredentials: async () => ({
clientId: config.client.preregistered?.clientId,
clientSecret: config.client.preregistered?.clientSecret,
Expand Down
Loading