Skip to content

stop rejecting http on byok#2315

Merged
ignaciojimenezr merged 5 commits into
mainfrom
http-byok
May 29, 2026
Merged

stop rejecting http on byok#2315
ignaciojimenezr merged 5 commits into
mainfrom
http-byok

Conversation

@ignaciojimenezr
Copy link
Copy Markdown
Collaborator

@ignaciojimenezr ignaciojimenezr commented May 28, 2026

  • we incorrectly had a server url check before contacting providers which rejected http servers
  • we don't do that any more when local

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 28, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@dosubot dosubot Bot added the bug Something isn't working label May 28, 2026
@chelojimenez
Copy link
Copy Markdown
Contributor

chelojimenez commented May 28, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bf40bbb9-02b9-44d0-bc72-3539290a782b

📥 Commits

Reviewing files that changed from the base of the PR and between 9f29bac and 401b390.

📒 Files selected for processing (1)
  • mcpjam-inspector/server/routes/web/__tests__/chat-v2.hosted.test.ts

Walkthrough

The PR imports HOSTED_MODE into the web auth route and updates authorizeBatch to conditionally add localRuntime: true to the JSON body sent to /web/authorize-batch when HOSTED_MODE is false, with comments describing the Convex hosted-mode HTTPS-only behavior. The rest of the authorization flow is unchanged.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Internal preview

Preview URL: https://mcp-inspector-pr-2315.up.railway.app
Deployed commit: 5096057
PR head commit: 401b390
Backend target: staging fallback.
Access is employee-only in non-production environments.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 29, 2026
@ignaciojimenezr ignaciojimenezr merged commit 3d7d38f into main May 29, 2026
11 checks passed
@ignaciojimenezr ignaciojimenezr deleted the http-byok branch May 29, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants