fix same-model non-opaque face culling#496
Closed
KaptainWutax wants to merge 1 commit into
Closed
Conversation
Owner
|
Nice catch on the cause of the error, just the wrong fix. |
Owner
|
|
Contributor
Author
|
Thank you! I misunderstood how |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so models require the same-model neighbor's opposite face to exist before culling. It is a strictly less aggressive cull strategy (anything that was not culled before remains unculled). Also worth noting:
DISABLE_CULL_SAME_OCCLUDESappears to do the opposite of what its name suggests and some of the comments may need updating.Before:

After:
