Skip to content

fix same-model non-opaque face culling#496

Closed
KaptainWutax wants to merge 1 commit into
MCRcortex:devfrom
KaptainWutax:dev-fix
Closed

fix same-model non-opaque face culling#496
KaptainWutax wants to merge 1 commit into
MCRcortex:devfrom
KaptainWutax:dev-fix

Conversation

@KaptainWutax

Copy link
Copy Markdown
Contributor

This change makes it so models require the same-model neighbor's opposite face to exist before culling. It is a strictly less aggressive cull strategy (anything that was not culled before remains unculled). Also worth noting: DISABLE_CULL_SAME_OCCLUDES appears to do the opposite of what its name suggests and some of the comments may need updating.

Before:
2026-04-25_13 47 05

After:
image

@MCRcortex

MCRcortex commented Apr 29, 2026

Copy link
Copy Markdown
Owner

Nice catch on the cause of the error, just the wrong fix. (ModelQueries.faceCanBeOccluded(meta, face)&&ModelQueries.faceOccludes(meta, face^1)) afak is the correct fix (implemented and tested and seems tobe working

@MCRcortex MCRcortex closed this Apr 29, 2026
@MCRcortex

Copy link
Copy Markdown
Owner

faceExists is for stuff like kelp, short/tall grass flowers etc where there is no visible geometry when looking straight down

@KaptainWutax

Copy link
Copy Markdown
Contributor Author

Thank you! I misunderstood how faceExists works here. Your fix is much better, appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants