fix(daemon): tolerate system info refresh failures

Author: lxhtt

MCServerLauncher.Daemon/Bootstrap/DaemonServiceComposition.cs

@@ -73,18 +73,25 @@ internal static void AttachDaemonLifecycle(HttpService httpService)
         daemonReportTimer.AutoReset = true;
         daemonReportTimer.Elapsed += async (sender, args) =>
         {
-            var eventService = httpService.Resolver.GetRequiredService<IEventService>();
-            var cell = httpService.Resolver.GetRequiredService<IAsyncTimedLazyCell<SystemInfo>>();
-            var systemInfo = await cell.Value;
-            eventService.OnDaemonReport(new DaemonReport(
-                systemInfo.Os,
-                systemInfo.Cpu,
-                systemInfo.Mem,
-                systemInfo.Drive,
-                Application.StartTime.ToUnixTimeMilliSeconds(),
-                systemInfo.Drives,
-                systemInfo.DaemonVersion
-            ));
+            try
+            {
+                var eventService = httpService.Resolver.GetRequiredService<IEventService>();
+                var cell = httpService.Resolver.GetRequiredService<IAsyncTimedLazyCell<SystemInfo>>();
+                var systemInfo = await cell.Value;
+                eventService.OnDaemonReport(new DaemonReport(
+                    systemInfo.Os,
+                    systemInfo.Cpu,
+                    systemInfo.Mem,
+                    systemInfo.Drive,
+                    Application.StartTime.ToUnixTimeMilliSeconds(),
+                    systemInfo.Drives,
+                    systemInfo.DaemonVersion
+                ));
+            }
+            catch (Exception ex)
+            {
+                Serilog.Log.Debug(ex, "[DaemonReport] Failed to refresh daemon report");
+            }
         };
         Application.OnStarted += () =>
         {

MCServerLauncher.Daemon/Utils/Status/CpuInfoHelper.cs

@@ -1,4 +1,5 @@
 using System.ComponentModel;
+using System.Globalization;
 using System.Runtime.InteropServices;
 using MCServerLauncher.Common.Helpers;
 using MCServerLauncher.Common.ProtoType.Status;
@@ -91,7 +92,7 @@ public static async Task<CpuInfo> GetCpuInfo()
             var cpuUsage =
                 await SystemInfoHelper.RunCommandAsync("sh",
                         "-c \"top -l 1 | grep 'CPU usage' | awk '{print $3}' | tr -d '%'\"")
-                    .MapTask(double.Parse);
+                    .MapTask(ParseMacOsCpuUsage);
 
             var name = await SystemInfoHelper.RunCommandAsync("sysctl", "-n machdep.cpu.brand_string");
             var vendor = name.Split(' ')[0];
@@ -113,6 +114,17 @@ await SystemInfoHelper.RunCommandAsync("sh",
         throw new NotSupportedException("Unsupported OS");
     }
 
+    internal static double ParseMacOsCpuUsage(string output)
+    {
+        return double.TryParse(
+            output.Trim(),
+            NumberStyles.Float,
+            CultureInfo.InvariantCulture,
+            out var usage)
+            ? usage
+            : 0;
+    }
+
     private static CpuInfo CreateCpuInfo(double usage)
     {
         return new CpuInfo(Vendor, Name, ThreadCount, usage, CoreCount, ThreadCount);

MCServerLauncher.ProtocolTests/SystemInfoFailureToleranceTests.cs

@@ -0,0 +1,26 @@
+using MCServerLauncher.Daemon.Utils.Status;
+
+namespace MCServerLauncher.ProtocolTests;
+
+public class SystemInfoFailureToleranceTests
+{
+    [Fact]
+    [Trait("Category", "Status")]
+    [Trait("Category", "FailureTolerance")]
+    public void ParseMacOsCpuUsage_EmptyTopOutput_ReturnsZero()
+    {
+        var usage = CpuInfoHelper.ParseMacOsCpuUsage("");
+
+        Assert.Equal(0, usage);
+    }
+
+    [Fact]
+    [Trait("Category", "Status")]
+    [Trait("Category", "FailureTolerance")]
+    public void ParseMacOsCpuUsage_PercentageOutput_ParsesValue()
+    {
+        var usage = CpuInfoHelper.ParseMacOsCpuUsage("12.34");
+
+        Assert.Equal(12.34, usage);
+    }
+}

docs/superpowers/plans/2026-06-19-daemon-status-failure-tolerance.md

@@ -0,0 +1,48 @@
+# Daemon Status Failure Tolerance Implementation Plan
+
+> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
+
+**Goal:** Prevent daemon shutdown or background report refresh from crashing when macOS CPU usage command output is empty or malformed.
+
+**Architecture:** Keep the existing system-info helpers. Add a small parser seam for macOS CPU usage and make the daemon-report timer callback contain system-info refresh failures.
+
+**Tech Stack:** C# 14, .NET 10, xUnit protocol tests.
+
+---
+
+## Touched Areas
+
+- `backend`
+- `tests`
+- `docs`
+
+## Tasks
+
+### Task 1: Reproduce CPU Usage Parse Failure
+
+**Files:**
+- Create: `MCServerLauncher.ProtocolTests/SystemInfoFailureToleranceTests.cs`
+
+- [x] Add a failing test for empty macOS CPU usage output.
+- [x] Add a passing baseline test for normal percentage output.
+
+### Task 2: Make Status Refresh Tolerant
+
+**Files:**
+- Modify: `MCServerLauncher.Daemon/Utils/Status/CpuInfoHelper.cs`
+- Modify: `MCServerLauncher.Daemon/Bootstrap/DaemonServiceComposition.cs`
+
+- [x] Parse macOS CPU usage with `double.TryParse` and return `0` when output is empty or invalid.
+- [x] Catch daemon-report timer refresh failures so background status refresh does not become an unhandled exception during shutdown.
+
+### Task 3: Verify
+
+**Commands:**
+- [x] `dotnet test MCServerLauncher.ProtocolTests/MCServerLauncher.ProtocolTests.csproj --filter FullyQualifiedName~SystemInfoFailureToleranceTests /m:1`
+- [x] `dotnet build MCServerLauncher.Daemon/MCServerLauncher.Daemon.csproj /m:1`
+- [x] `dotnet test MCServerLauncher.ProtocolTests/MCServerLauncher.ProtocolTests.csproj /m:1`
+- [x] `git diff --check`
+
+## Changelog
+
+- 2026-06-19: Added macOS CPU usage parse fallback and contained daemon-report timer refresh failures.