Finished tests for mda.start_logging() and mda.stop_logging()

Author: jauy123

package/MDAnalysis/lib/log.py

@@ -119,8 +119,8 @@ def start_logging(stream="MDAnalysis.log", version=version.__version__):
         level="INFO",
         fmt="%(name)-12s: %(levelname)-8s %(message)s",
     )
-    logging.getLogger(__name__).info(
-        f"MDAnalysis {version} STARTED logging to {stream!r}"
+    logging.getLogger("MDAnalysis").info(
+        f"MDAnalysis {version} STARTED logging to {stream}"
     )
 
 
@@ -174,6 +174,7 @@ def create(
 
     # replaced with logging.getLogger(__name__)
     logger = logging.getLogger(logger_name)
+    logger.setLevel(logging.DEBUG)
 
     # This checks for file-like object per duck typing
     # https://docs.python.org/3/library/logging.handlers.html#streamhandler

testsuite/MDAnalysisTests/lib/test_log.py

@@ -24,12 +24,22 @@
 import pytest
 import sys
 import logging
+import time
 import MDAnalysis as mda
 
 from os.path import basename
 from MDAnalysis.lib.log import ProgressBar
 
 
+@pytest.fixture
+def fixed_log_time(monkeypatch):
+    """Pytest fixture which temporarily set the logging's t0 to the UNIX epoc"""
+    epoch = 0
+
+    monkeypatch.setattr(logging.time, "time", lambda: epoch)
+    monkeypatch.setattr(logging.Formatter, "converter", time.gmtime)
+
+
 class TestConvenienceFunctions:
     def test_start_logging(self, tmp_path):
         mda.start_logging(tmp_path / "MDAnalysis.log")
@@ -57,11 +67,26 @@ def test_stop_logging(self, tmp_path):
 
         assert len(logger.handlers) == 0
 
-def test_message_console(tmp_path):
-    pass
+    def test_message_file(self, tmp_path, fixed_log_time):
+
+        mda.start_logging(tmp_path / "MDAnalysis.log")
+
+        with open(tmp_path / "MDAnalysis.log") as f:
+
+            assert (
+                "1970-01-01 00:00:00,000 MDAnalysis   INFO     "
+                + f"MDAnalysis {mda.version.__version__} STARTED logging to {str(tmp_path)}"
+            )
+
+    def test_message_console(self, tmp_path, capsys):
+        mda.start_logging(tmp_path / "MDAnalysis.log")
+
+        assert (
+            "MDAnalysis  : INFO     "
+            + f"MDAnalysis {mda.version.__version__} STARTED logging to {str(tmp_path)}"
+            in capsys.readouterr().out
+        )
 
-def test_message_file(tmp_path):
-    pass
 
 # TODO need to make a fixture that can clear all handlers per test
 class TestCreateBehaviors:
@@ -93,15 +118,19 @@ def test_exception(tmp_path):
         ):
             mda.lib.log.create(stream=2)
 
+
 def test_level_parameter():
     pass
 
+
 def test_fmt_parameter():
     pass
 
+
 def test_mode_parameter():
     pass
 
+
 class TestProgressBar(object):
 
     def test_output(self, capsys):