Why does __init__ try to import __authors__ ?

[jauy123]

Come from here (#5367 (comment)), but why does this bit code exists in the top level __init__?

logger = logging.getLogger("MDAnalysis.__init__")

from .version import __version__

try:
    from .authors import __authors__
except ImportError:
    logger.info("Could not find authors.py, __authors__ will be empty.")
    __authors__ = []

I removed the try block and the logging stuff and my testsuite works fine:

from .version import __version__
from .authors import __authors__

[jeremyleung521]

So __authors__ is a PEP8-sanctioned "dunder", but it's pulling from authors.py, which doesn't seem to exist now. I think nowadays the authorship is listed under pyproject.toml or setup.py so it's probably ok to remove. import MDAnalysis as mda; print(mda.__authors__) is supposed to print the authors, but I don't think most people do this anymore.

https://peps.python.org/pep-0008/#module-level-dunder-names
https://stackoverflow.com/questions/9531136/what-is-the-origin-of-author

If you're doing the removal, this test should also be removed: https://github.com/MDAnalysis/mdanalysis/blob/develop/testsuite/MDAnalysisTests/utils/test_authors.py

Similarly, since calling setup.py directly is no longer kosher, these related lines/functions about authors will never run, so could also be removed.
https://github.com/MDAnalysis/mdanalysis/blob/develop/package/setup.py#L539-L611
https://github.com/MDAnalysis/mdanalysis/blob/develop/package/setup.py#L628-L631

EDIT crossed out incorrect suggestions/assumptions

[IAlibay]

I'm not sure about this - I believe the dynamic authors list is being used in docs. We'd have to check it doesn't break anything there.

[jeremyleung521]

I just had a deeper look (sorry just looked at package earlier), looks like authors.py gets generated dynamically during install and __author__ is used in docs config. Seems like the __name__ == "__main__" block does get executed by setuptools on install, my bad!

So yes, removing it is not a good idea. Disregard all of my suggestions above!

[jauy123]

Ok, cool! Was just wondering why this block of code was there in the first place! Thanks for answering!

[orbeckst]

Linking to my comment on the PR #5367 (comment) — just in case people come across this question again.