standardize logging.getLogger() to use __name__ (Issue #5369)#5376
Open
Jatin-Khiyani wants to merge 1 commit intoMDAnalysis:developfrom
Open
standardize logging.getLogger() to use __name__ (Issue #5369)#5376Jatin-Khiyani wants to merge 1 commit intoMDAnalysis:developfrom
Jatin-Khiyani wants to merge 1 commit intoMDAnalysis:developfrom
Conversation
Replace hardcoded logger name strings with __name__ across analysis, coordinates, topology, converters, core and guesser modules. Some modules had mismatched names (e.g. coordinates/TRJ.py used "AMBER", coordinates/PDB.py had typo "PBD") — these are now corrected as a side effect of this change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5376 +/- ##
========================================
Coverage 93.85% 93.85%
========================================
Files 182 182
Lines 22505 22505
Branches 3200 3200
========================================
+ Hits 21121 21122 +1
Misses 922 922
+ Partials 462 461 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5369
Changes made in this Pull Request
logging.getLogger("MDAnalysis.x.y")with
logging.getLogger(__name__)across analysis, coordinates,topology, converters, core and guesser modules as per issue logging.getLogger() should follow a standardized syntax. #5369 request.
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used
in this contribution: yes
Used to understand the codebase and the existing logging patterns.
All code changes were made manually following the guidance in the issue.
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS?Developers Certificate of Origin
I certify that I can submit this code contribution as described in the
Developer Certificate of Origin,
under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5376.org.readthedocs.build/en/5376/