Publishing expanded reading history#83
Conversation
Co-authored-by: Taylor Salo <tsalo90@gmail.com> Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
|
I think that's a good policy. I'm a little worried about the size of this change. I'd expect it to only affect the built version of the recommended reading page, but it looks like there are a lot of other changed files. |
|
It looks like some files have hashes in their file names so maybe they change? Another factor is floating point errors. Every execution will generate slightly different volumes, so they are effectively new files (unless just a different time stamp is enough to add a file to the commit.) Is there any non-painful way for That said, some images do look different. For example: This is random each iteration, with no set seed, so that's what's happening. I'd expect anything post ICA to actually change. |
I realized I didn't run
make site-publishbefore merging.@tsalo Thoughts on best practices for this? Once someone approves a PR, the submitter then runs
make site-publishon the same PR before merging?