Skip to content

add calc_gaspari_cohn_correlation_matrices#300

Merged
mathause merged 4 commits into
MESMER-group:mainfrom
mathause:add_gaspari_cohn_correlation_matrices
Sep 21, 2023
Merged

add calc_gaspari_cohn_correlation_matrices#300
mathause merged 4 commits into
MESMER-group:mainfrom
mathause:add_gaspari_cohn_correlation_matrices

Conversation

@mathause
Copy link
Copy Markdown
Member

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

Add function to calculate Gaspari-Cohn correlation matrices for a range of localisation radii. Again, blatantly stolen from #109, so @znicholls should really get the credit here. I pass geodist instead of lon, lat because I still intend to do #62 and for this it is much easier if we pass the geodist directly. Makes it also a bit more explicit what is happening.

The tests are crap - they repeat the code in the function, which renders almost worthless. Still it checks that it is run.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (1358e63) 86.89% compared to head (0dd31ef) 86.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   86.89%   86.92%   +0.02%     
==========================================
  Files          38       38              
  Lines        1580     1583       +3     
==========================================
+ Hits         1373     1376       +3     
  Misses        207      207              
Flag Coverage Δ
unittests 86.92% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mesmer/core/computation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Copy Markdown
Member Author

I'm ignoring the faulty rtd built. I think it's a fluke.

@mathause mathause merged commit f5c9d1e into MESMER-group:main Sep 21, 2023
@mathause mathause deleted the add_gaspari_cohn_correlation_matrices branch September 21, 2023 21:17
mathause added a commit that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant