Fix value_labels rendering, substring matching, and misleading comment

- docs_gen.py: Render value_labels in Constraints column instead of
  skipping them, fixing 12 params that lost valid-value info
- case_validator.py: Use word-boundary regex for CONSTRAINTS hint
  matching to prevent false matches on short param names
- ast_analyzer.py: Use word-boundary regex for 'must be 1' pattern
  to avoid matching 'must be 10', 'must be 100', etc.
- definitions.py: Fix misleading comment in _lookup_hint()

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: sbryngelson

toolchain/mfc/case_validator.py

@@ -14,6 +14,7 @@
 # pylint: disable=too-many-lines
 # Justification: Comprehensive validator covering all MFC parameter constraints
 
+import re
 from typing import Dict, Any, List, Set
 from functools import lru_cache
 from .common import MFCException
@@ -1937,7 +1938,7 @@ def _format_errors(self) -> str:
 
             # Auto-generate hints from CONSTRAINTS with value_labels
             for param_name, constraint in CONSTRAINTS.items():
-                if param_name not in err_lower:
+                if not re.search(r'\b' + re.escape(param_name) + r'\b', err_lower):
                     continue
                 choices = constraint.get("choices")
                 if not choices:

toolchain/mfc/params/ast_analyzer.py

@@ -9,6 +9,7 @@
 from __future__ import annotations
 
 import ast
+import re
 from dataclasses import dataclass, field
 from pathlib import Path
 from typing import Dict, List, Optional, Set
@@ -675,7 +676,7 @@ def classify_message(msg: str) -> str:
         or "must be >=" in text
         or "must be odd" in text
         or "divisible by" in text
-        or "must be 1" in text
+        or re.search(r"must be 1\b", text) is not None
         or "must be 'T' or 'F'" in text
     ):
         return "range"

toolchain/mfc/params/definitions.py

@@ -436,10 +436,10 @@ def _lookup_hint(name):
         return ""
     # Compound name: extract family and attribute
     prefix, attr_full = name.split('%', 1)
-    # Normalize family: "bc_x" → "bc", "patch_bc(1)" → "patch_bc"
-    family = re.sub(r'[_(].*', '', prefix)  # "bc_x" → "bc", "patch_bc" stays
+    # Normalize family: "bc_x" → "bc", "patch_bc(1)" → "patch"
+    family = re.sub(r'[_(].*', '', prefix)
     if family not in HINTS:
-        # Try with underscore-joined prefix: "simplex_params" stays
+        # Fallback: keep underscores — "patch_bc" → "patch_bc", "simplex_params" → "simplex_params"
         family = re.match(r'^[a-zA-Z_]+', prefix).group(0)
     if family not in HINTS:
         return ""

toolchain/mfc/params/generators/docs_gen.py

@@ -103,14 +103,20 @@ def _type_to_str(param_type: ParamType) -> str:
 
 
 def _format_constraints(param) -> str:
-    """Format constraints as readable string, skipping choices already shown via value_labels."""
+    """Format constraints as readable string with value labels when available."""
     if not param.constraints:
         return ""
 
     parts = []
     c = param.constraints
-    if "choices" in c and "value_labels" not in c:
-        parts.append(f"Values: {c['choices']}")
+    if "choices" in c:
+        labels = c.get("value_labels", {})
+        if labels:
+            items = [f"{v}={labels[v]}" if v in labels else str(v)
+                     for v in c["choices"]]
+            parts.append(", ".join(items))
+        else:
+            parts.append(f"Values: {c['choices']}")
     if "min" in c:
         parts.append(f"Min: {c['min']}")
     if "max" in c: