Skip to content

Commit 0d2d33f

Browse files
committed
fix HLLC ADC parity, precision, docs, examples
1 parent c32a52b commit 0d2d33f

23 files changed

Lines changed: 803 additions & 685 deletions

File tree

docs/documentation/case.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ It is recommended to set `weno_eps` to $10^{-6}$ for WENO-JS, and to $10^{-40}$
550550

551551
- `riemann_solver` specifies the choice of the Riemann solver that is used in simulation by an integer from 1 through 4.
552552
`riemann_solver = 1`, `2`, and `3` correspond to HLL, HLLC, and Exact Riemann solver, respectively (\cite Toro09).
553-
`riemann_solver = 4` is only for MHD simulations. It resolves 5 of the full seven-wave structure of the MHD equations (\cite Miyoshi05).
553+
`riemann_solver = 4` is the HLLD solver for MHD or hypoelasticity simulations. For MHD it resolves 5 of the full seven-wave structure of the MHD equations (\cite Miyoshi05).
554554

555555
- `hll_u_interface`: Selects between two HLL discretizations of volume fraction advection (`riemann_solver = 1`):
556556
- **Default** (``'F'``): \f$\partial_t \alpha_k + u\,\partial_x \alpha_k = 0\f$

examples/2D_axisym_hypo_hlld/case.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
#!/usr/bin/env python3
22
import json
3-
import math
43

54
# 2D axisymmetric hypoelastic case with HLLD solver.
65
# Solid sphere in liquid hit by focused acoustic pulse.
7-
# Adapted from HLL_new/circle_1_interface for cylindrical coordinates.
8-
# x = axial, y = radial (axis of symmetry at y = 0).
96

107
config = {
118
"run_time_info": "T",
129
# Computational Domain
13-
"x_domain%beg": 0,
10+
"x_domain%beg": 0.0,
1411
"x_domain%end": 1.0,
15-
"y_domain%beg": 0,
12+
"y_domain%beg": 0.0,
1613
"y_domain%end": 1.0,
1714
"cyl_coord": "T",
1815
"m": 49,
@@ -35,7 +32,6 @@
3532
"null_weights": "F",
3633
"mp_weno": "F",
3734
"riemann_solver": 4,
38-
# "hypo_hll_interface_rhs": "T",
3935
"wave_speeds": 1,
4036
"avg_state": 2,
4137
"bc_x%beg": -2,

examples/2D_axisym_hypo_hlld_riemann/case.py

Lines changed: 0 additions & 93 deletions
This file was deleted.

examples/2D_hypo_hlld/case.py

Lines changed: 7 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#!/usr/bin/env python3
22
import json
3-
import math
43

54
config = {
6-
# Logistics
75
"run_time_info": "T",
8-
# Computational Domain Parameters
9-
"x_domain%beg": 0,
6+
# Computational Domain
7+
"x_domain%beg": 0.0,
108
"x_domain%end": 1.0,
11-
"y_domain%beg": 0,
9+
"y_domain%beg": 0.0,
1210
"y_domain%end": 1.0,
1311
"m": 49,
1412
"n": 49,
@@ -17,46 +15,35 @@
1715
"t_step_start": 0,
1816
"t_step_stop": 250,
1917
"t_step_save": 50,
20-
# Simulation Algorithm Parameters
18+
# Simulation Algorithm
2119
"num_patches": 2,
2220
"model_eqns": 2,
2321
"alt_soundspeed": "F",
2422
"num_fluids": 2,
25-
# "mpp_lim": "F",
2623
"mpp_lim": "T",
2724
"mixture_err": "F",
2825
"time_stepper": 1,
2926
"weno_order": 1,
3027
"weno_eps": 1.0e-20,
31-
# "mapped_weno": "T",
3228
"null_weights": "F",
3329
"mp_weno": "F",
34-
# "riemann_solver": 2,
3530
"riemann_solver": 4,
36-
# "riemann_hypo_ADC": 'T',
37-
# "ADC_kappa": 1.0,
3831
"wave_speeds": 1,
3932
"avg_state": 2,
40-
# "bc_x%beg": -6,
41-
# "bc_x%end": -6,
42-
# "bc_y%beg": -6,
43-
# "bc_y%end": -6,
4433
"bc_x%beg": -3,
4534
"bc_x%end": -3,
4635
"bc_y%beg": -3,
4736
"bc_y%end": -3,
48-
# !!! BC=-6 doesn't work with 1st order upwind !!!
49-
# Formatted Database Files Structure Parameters
37+
# Output
5038
"format": 1,
51-
# "format": 2,
5239
"precision": 2,
5340
"prim_vars_wrt": "T",
5441
"rho_wrt": "T",
5542
"parallel_io": "T",
5643
# Hypoelasticity
5744
"hypoelasticity": "T",
5845
"fd_order": 4,
59-
# Patch 1 Liquid
46+
# Patch 1: Liquid background
6047
"patch_icpp(1)%geometry": 3,
6148
"patch_icpp(1)%x_centroid": 0.5,
6249
"patch_icpp(1)%y_centroid": 0.5,
@@ -70,7 +57,7 @@
7057
"patch_icpp(1)%alpha(1)": 1.0 - 1e-8,
7158
"patch_icpp(1)%alpha_rho(2)": 1000 * 1e-8,
7259
"patch_icpp(1)%alpha(2)": 1e-8,
73-
# Patch 1 Solid
60+
# Patch 2: Solid circle
7461
"patch_icpp(2)%alter_patch(1)": "T",
7562
"patch_icpp(2)%geometry": 2,
7663
"patch_icpp(2)%x_centroid": 0.6,
@@ -84,9 +71,6 @@
8471
"patch_icpp(2)%alpha(1)": 1e-8,
8572
"patch_icpp(2)%alpha_rho(2)": 1000 * (1.0 - 1e-8),
8673
"patch_icpp(2)%alpha(2)": 1.0 - 1e-8,
87-
# "patch_icpp(2)%smoothen": "T",
88-
# "patch_icpp(2)%smooth_patch_id": 1,
89-
# "patch_icpp(2)%smooth_coeff": 4.0e00,
9074
# Acoustic source
9175
"acoustic_source": "T",
9276
"num_source": 1,

examples/2D_hypo_hlld_riemann/case.py

Lines changed: 0 additions & 91 deletions
This file was deleted.

examples/3D_hypo_hlld/case.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
#!/usr/bin/env python3
22
import json
3-
import math
3+
4+
# 3D hypoelastic case with HLLD solver.
5+
# Solid sphere in liquid hit by focused acoustic pulse.
46

57
config = {
6-
# Logistics
78
"run_time_info": "T",
8-
# Computational Domain Parameters
9-
"x_domain%beg": 0,
9+
# Computational Domain
10+
"x_domain%beg": 0.0,
1011
"x_domain%end": 1.0,
11-
"y_domain%beg": 0,
12+
"y_domain%beg": 0.0,
1213
"y_domain%end": 1.0,
13-
"z_domain%beg": 0,
14+
"z_domain%beg": 0.0,
1415
"z_domain%end": 1.0,
1516
"m": 24,
1617
"n": 24,

0 commit comments

Comments
 (0)