Addressed AI review comments

Author: danieljvickers

src/post_process/m_data_output.fpp

@@ -1364,28 +1364,28 @@ contains
         real(wp), dimension(:), allocatable             :: angle_x, angle_y, angle_z
         real(wp), dimension(:), allocatable             :: ib_diameter
 
-        ! Build path to per-timestep IB state file
-        write (file_loc, '(A,I0,A)') '/restart_data/ib_state_', t_step, '.dat'
-        file_loc = trim(case_dir) // trim(file_loc)
+        if (proc_rank == 0) then
+            ! Build path to per-timestep IB state file
+            write (file_loc, '(A,I0,A)') '/restart_data/ib_state_', t_step, '.dat'
+            file_loc = trim(case_dir) // trim(file_loc)
 
-        inquire (FILE=trim(file_loc), EXIST=file_exist)
-        if (.not. file_exist) then
-            call s_mpi_abort('Restart file ' // trim(file_loc) // ' does not exist!')
-        end if
+            inquire (FILE=trim(file_loc), EXIST=file_exist)
+            if (.not. file_exist) then
+                call s_mpi_abort('Restart file ' // trim(file_loc) // ' does not exist!')
+            end if
 
-        nBodies = num_ibs
+            nBodies = num_ibs
 
-        if (nBodies > 0) then
-            allocate (ib_data(nBodies, NFIELDS_PER_IB))
-            allocate (px(nBodies), py(nBodies), pz(nBodies))
-            allocate (force_x(nBodies), force_y(nBodies), force_z(nBodies))
-            allocate (torque_x(nBodies), torque_y(nBodies), torque_z(nBodies))
-            allocate (vel_x(nBodies), vel_y(nBodies), vel_z(nBodies))
-            allocate (omega_x(nBodies), omega_y(nBodies), omega_z(nBodies))
-            allocate (angle_x(nBodies), angle_y(nBodies), angle_z(nBodies))
-            allocate (ib_diameter(nBodies))
+            if (nBodies > 0) then
+                allocate (ib_data(nBodies, NFIELDS_PER_IB))
+                allocate (px(nBodies), py(nBodies), pz(nBodies))
+                allocate (force_x(nBodies), force_y(nBodies), force_z(nBodies))
+                allocate (torque_x(nBodies), torque_y(nBodies), torque_z(nBodies))
+                allocate (vel_x(nBodies), vel_y(nBodies), vel_z(nBodies))
+                allocate (omega_x(nBodies), omega_y(nBodies), omega_z(nBodies))
+                allocate (angle_x(nBodies), angle_y(nBodies), angle_z(nBodies))
+                allocate (ib_diameter(nBodies))
 
-            if (proc_rank == 0) then
                 open (newunit=file_unit, file=trim(file_loc), form='unformatted', access='stream', status='old', iostat=ios)
                 if (ios /= 0) call s_mpi_abort('Cannot open IB state file: ' // trim(file_loc))
 
@@ -1430,12 +1430,12 @@ contains
                 call s_write_ib_variable('ib_angle_y', t_step, angle_y, nBodies)
                 call s_write_ib_variable('ib_angle_z', t_step, angle_z, nBodies)
                 call s_write_ib_variable('ib_diameter', t_step, ib_diameter, nBodies)
-            end if
 
-            deallocate (ib_data, px, py, pz, force_x, force_y, force_z)
-            deallocate (torque_x, torque_y, torque_z, vel_x, vel_y, vel_z)
-            deallocate (omega_x, omega_y, omega_z, angle_x, angle_y, angle_z)
-            deallocate (ib_diameter)
+                deallocate (ib_data, px, py, pz, force_x, force_y, force_z)
+                deallocate (torque_x, torque_y, torque_z, vel_x, vel_y, vel_z)
+                deallocate (omega_x, omega_y, omega_z, angle_x, angle_y, angle_z)
+                deallocate (ib_diameter)
+            end if
         end if
 #endif
 

src/simulation/m_collisions.fpp

@@ -440,8 +440,6 @@ contains
     !> @brief function checks if this local MPI processor owns this specific collision
     function f_neighborhood_ranks_own_location(location) result(owns_collision)
 
-        $:GPU_ROUTINE(parallelism='[seq]')
-
         real(wp), dimension(3), intent(in) :: location
         logical                            :: owns_collision, periodic_owner
         real(wp)                           :: temp_neighbor_domain

src/simulation/m_start_up.fpp

@@ -1227,6 +1227,8 @@ contains
 
         num_gbl_ibs = num_ibs
         num_local_ibs = num_ibs
+        @:PROHIBIT(num_local_ibs > num_local_ibs_max, &
+                   & "Too many IBs on a single processor rank. Modify case file or increase limit of num_local_ibs_max to resolve.")
         do i = 1, num_local_ibs_max
             local_ib_patch_ids(i) = i
         end do