Skip to content

Commit 325cb73

Browse files
committed
feat: rename container tags to gpu-nvidia / gpu-amd for clarity
Hard-cut from old names: -gpu → -gpu-nvidia, -amd → -gpu-amd. Also fixes AMD build step to use lowercase GH_REGISTRY and corrects the DockerHub environment URL to mflowcode/mfc.
1 parent 9c34310 commit 325cb73

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

.github/workflows/docker.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ jobs:
2424
strategy:
2525
matrix:
2626
config:
27-
- { name: 'cpu', runner: 'ubuntu-22.04', base_image: 'ubuntu:22.04' }
28-
- { name: 'cpu', runner: 'ubuntu-22.04-arm', base_image: 'ubuntu:22.04' }
29-
- { name: 'gpu', runner: 'ubuntu-22.04', base_image: 'nvcr.io/nvidia/nvhpc:24.5-devel-cuda_multi-ubuntu22.04', compiler_arch: 'Linux_x86_64' }
30-
- { name: 'gpu', runner: 'ubuntu-22.04-arm', base_image: 'nvcr.io/nvidia/nvhpc:24.5-devel-cuda_multi-ubuntu22.04', compiler_arch: 'Linux_aarch64' }
31-
- { name: 'amd', runner: 'ubuntu-22.04', base_image: 'ubuntu:22.04' }
27+
- { name: 'cpu', tag: 'cpu', runner: 'ubuntu-22.04', base_image: 'ubuntu:22.04' }
28+
- { name: 'cpu', tag: 'cpu', runner: 'ubuntu-22.04-arm', base_image: 'ubuntu:22.04' }
29+
- { name: 'gpu', tag: 'gpu-nvidia', runner: 'ubuntu-22.04', base_image: 'nvcr.io/nvidia/nvhpc:24.5-devel-cuda_multi-ubuntu22.04', compiler_arch: 'Linux_x86_64' }
30+
- { name: 'gpu', tag: 'gpu-nvidia', runner: 'ubuntu-22.04-arm', base_image: 'nvcr.io/nvidia/nvhpc:24.5-devel-cuda_multi-ubuntu22.04', compiler_arch: 'Linux_aarch64' }
31+
- { name: 'amd', tag: 'gpu-amd', runner: 'ubuntu-22.04', base_image: 'ubuntu:22.04' }
3232
runs-on: ${{ matrix.config.runner }}
3333
outputs:
3434
tag: ${{ steps.clone.outputs.tag }}
@@ -109,8 +109,8 @@ jobs:
109109
labels: |
110110
org.opencontainers.image.source=https://github.com/${{ github.repository }}
111111
tags: |
112-
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-${{ matrix.config.name }}-${{ matrix.config.runner }}
113-
${{ env.GH_REGISTRY }}:${{ env.TAG }}-${{ matrix.config.name }}-${{ matrix.config.runner }}
112+
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-${{ matrix.config.tag }}-${{ matrix.config.runner }}
113+
${{ env.GH_REGISTRY }}:${{ env.TAG }}-${{ matrix.config.tag }}-${{ matrix.config.runner }}
114114
push: true
115115

116116
- name: Build and push image (gpu)
@@ -131,8 +131,8 @@ jobs:
131131
labels: |
132132
org.opencontainers.image.source=https://github.com/${{ github.repository }}
133133
tags: |
134-
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-${{ matrix.config.name }}-${{ matrix.config.runner }}
135-
${{ env.GH_REGISTRY }}:${{ env.TAG }}-${{ matrix.config.name }}-${{ matrix.config.runner }}
134+
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-${{ matrix.config.tag }}-${{ matrix.config.runner }}
135+
${{ env.GH_REGISTRY }}:${{ env.TAG }}-${{ matrix.config.tag }}-${{ matrix.config.runner }}
136136
push: true
137137

138138
- name: Build and push image (amd)
@@ -154,16 +154,16 @@ jobs:
154154
labels: |
155155
org.opencontainers.image.source=https://github.com/${{ github.repository }}
156156
tags: |
157-
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-amd-ubuntu-22.04
158-
ghcr.io/${{ github.repository_owner }}/mfc:${{ env.TAG }}-amd-ubuntu-22.04
157+
${{ secrets.DOCKERHUB_USERNAME }}/mfc:${{ env.TAG }}-gpu-amd-ubuntu-22.04
158+
${{ env.GH_REGISTRY }}:${{ env.TAG }}-gpu-amd-ubuntu-22.04
159159
push: true
160160

161161
manifests:
162162
runs-on: ubuntu-latest
163163
needs: Container
164164
environment:
165165
name: containers
166-
url: https://hub.docker.com/r/sbryngelson/mfc
166+
url: https://hub.docker.com/r/mflowcode/mfc
167167
steps:
168168
- name: Login to Docker Hub
169169
uses: docker/login-action@v3
@@ -193,9 +193,9 @@ jobs:
193193
run: |
194194
GH="${{ env.GH_REGISTRY }}"
195195
for R in "$DH" "$GH"; do
196-
docker buildx imagetools create -t $R:$TAG-cpu $R:$TAG-cpu-ubuntu-22.04 $R:$TAG-cpu-ubuntu-22.04-arm
197-
docker buildx imagetools create -t $R:$TAG-gpu $R:$TAG-gpu-ubuntu-22.04 $R:$TAG-gpu-ubuntu-22.04-arm
198-
docker buildx imagetools create -t $R:$TAG-amd $R:$TAG-amd-ubuntu-22.04
196+
docker buildx imagetools create -t $R:$TAG-cpu $R:$TAG-cpu-ubuntu-22.04 $R:$TAG-cpu-ubuntu-22.04-arm
197+
docker buildx imagetools create -t $R:$TAG-gpu-nvidia $R:$TAG-gpu-nvidia-ubuntu-22.04 $R:$TAG-gpu-nvidia-ubuntu-22.04-arm
198+
docker buildx imagetools create -t $R:$TAG-gpu-amd $R:$TAG-gpu-amd-ubuntu-22.04
199199
done
200200
201201
- name: Update latest tags
@@ -206,7 +206,7 @@ jobs:
206206
run: |
207207
GH="${{ env.GH_REGISTRY }}"
208208
for R in "$DH" "$GH"; do
209-
docker buildx imagetools create -t $R:latest-cpu $R:$TAG-cpu-ubuntu-22.04 $R:$TAG-cpu-ubuntu-22.04-arm
210-
docker buildx imagetools create -t $R:latest-gpu $R:$TAG-gpu-ubuntu-22.04 $R:$TAG-gpu-ubuntu-22.04-arm
211-
docker buildx imagetools create -t $R:latest-amd $R:$TAG-amd-ubuntu-22.04
209+
docker buildx imagetools create -t $R:latest-cpu $R:$TAG-cpu-ubuntu-22.04 $R:$TAG-cpu-ubuntu-22.04-arm
210+
docker buildx imagetools create -t $R:latest-gpu-nvidia $R:$TAG-gpu-nvidia-ubuntu-22.04 $R:$TAG-gpu-nvidia-ubuntu-22.04-arm
211+
docker buildx imagetools create -t $R:latest-gpu-amd $R:$TAG-gpu-amd-ubuntu-22.04
212212
done

0 commit comments

Comments
 (0)