Skip to content

Commit 357f1b5

Browse files
sbryngelsonclaude
andcommitted
Clarify non-dimensional variables and add consistency warning
- Note that R, R0, Rdot in the bubble equation are non-dimensional - Add explicit warning that all inputs must use the same reference scales when bubbles are enabled Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3a8806c commit 357f1b5

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

docs/documentation/equations.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ The sub-grid bubble models (`bubbles_euler = .true.` or `bubbles_lagrange = .tru
4343

4444
\f[p_{bw} = \left(\text{Ca} + \frac{2}{\text{We}_b\,R_0}\right)\left(\frac{R_0}{R}\right)^{3\gamma} - \text{Ca} - \frac{4\,\text{Re}_{\text{inv}}\,\dot{R}}{R} - \frac{2}{R\,\text{We}_b}\f]
4545

46-
where the dimensionless groups are:
46+
Here \f$R\f$ and \f$R_0\f$ are non-dimensional radii (scaled by \f$x_0\f$), and \f$\dot{R}\f$ is a non-dimensional wall speed (scaled by \f$u_0\f$); the entire bubble ODE is solved in non-dimensional variables.
47+
48+
The dimensionless groups are:
4749

4850
| Dimensionless group | Definition | Code variable | Computed from |
4951
|---|---|---|---|
@@ -52,7 +54,7 @@ where the dimensionless groups are:
5254
| \f$\text{We}_b\f$ (bubble Weber number) | \f$1/\sigma\f$ | `Web` | `1 / bub_pp%ss` |
5355
| \f$\text{Re}_{\text{inv}}\f$ (inverse bubble Reynolds number) | \f$\mu_l\f$ | `Re_inv` | `bub_pp%mu_l` |
5456

55-
These groups are computed during bubble-parameter initialization in `src/common/m_helper.fpp` (see subroutine `s_initialize_bubble_vars`). Because the bubble equations use these dimensionless numbers directly, all dimensional bubble inputs (pressures, viscosities, surface tension, etc.) in `bub_pp%` must be supplied in non-dimensional form by the user. The code does not perform any internal non-dimensionalization of these quantities.
57+
These groups are computed during bubble-parameter initialization in `src/common/m_helper.fpp` (see subroutine `s_initialize_bubble_vars`). Because the bubble equations use these dimensionless numbers directly, all dimensional bubble inputs (pressures, viscosities, surface tension, etc.) in `bub_pp%` must be supplied in non-dimensional form by the user. The code does not perform any internal non-dimensionalization of these quantities. When bubbles are enabled, **all** inputs — flow ICs/BCs, EOS parameters, domain lengths, `dt`, and `bub_pp%` values — must be scaled with the same reference quantities, or the coupled solution will be physically incorrect.
5658

5759
### Reference Scales
5860

0 commit comments

Comments
 (0)