You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Address reviewer feedback on dimensional analysis docs
- Reference subroutine name instead of brittle line numbers
- Add missing bub_pp%vd (vapor diffusivity) to parameter table
- Clarify M_v/M_g are not dimensionless but only used in ratios
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These groups are computed in `src/common/m_helper.fpp` (lines 143--194). Because the bubble equations use these dimensionless numbers directly, **all**`bub_pp%`parameters must be provided in non-dimensional form by the user. The code does not perform any internal non-dimensionalization of these inputs.
55
+
These groups are computed during bubble-parameter initialization in `src/common/m_helper.fpp` (see subroutine `s_initialize_bubble_vars`). Because the bubble equations use these dimensionless numbers directly, all dimensional bubble inputs (pressures, viscosities, surface tension, etc.) in `bub_pp%` must be supplied in non-dimensional form by the user. The code does not perform any internal non-dimensionalization of these quantities.
56
56
57
57
### Reference Scales
58
58
@@ -82,6 +82,7 @@ The following table lists every `bub_pp%` parameter and its required non-dimensi
0 commit comments