fix: address remaining files in deallocate audit

- m_rhs: fix incomplete qL_prim/qR_prim teardown by walking
  nested %vf/%sf structure before deallocating containers
- m_boundary_common: replace plain deallocate with @:DEALLOCATE
- m_mpi_common: replace plain deallocate with @:DEALLOCATE,
  mirror unified memory path in finalization
- m_variables_conversion: add missing @:DEALLOCATE for Res_vc
- m_start_up (post_process): annotate FFT arrays as program-lifetime
- m_helper, m_model, m_acoustic_src, m_bubbles_EE, m_qbmm:
  annotate allocations as program-lifetime (no finalize subroutine)

Part of #1459

Author: SVS87

src/common/m_boundary_common.fpp

@@ -171,23 +171,22 @@ contains
     subroutine s_finalize_boundary_common_module()
 
         if (bc_io) then
-            deallocate (bc_buffers(1, 1)%sf)
-            deallocate (bc_buffers(1, 2)%sf)
+            @:DEALLOCATE(bc_buffers(1, 1)%sf)
+            @:DEALLOCATE(bc_buffers(1, 2)%sf)
             #:if not MFC_CASE_OPTIMIZATION or num_dims > 1
                 if (n > 0) then
-                    deallocate (bc_buffers(2, 1)%sf)
-                    deallocate (bc_buffers(2, 2)%sf)
+                    @:DEALLOCATE(bc_buffers(2, 1)%sf)
+                    @:DEALLOCATE(bc_buffers(2, 2)%sf)
                     #:if not MFC_CASE_OPTIMIZATION or num_dims > 2
                         if (p > 0) then
-                            deallocate (bc_buffers(3, 1)%sf)
-                            deallocate (bc_buffers(3, 2)%sf)
+                            @:DEALLOCATE(bc_buffers(3, 1)%sf)
+                            @:DEALLOCATE(bc_buffers(3, 2)%sf)
                         end if
                     #:endif
                 end if
             #:endif
         end if
-
-        deallocate (bc_buffers)
+        @:DEALLOCATE(bc_buffers)
 
     end subroutine s_finalize_boundary_common_module
 

src/common/m_helper.fpp

@@ -86,6 +86,8 @@ contains
     impure subroutine s_initialize_bubbles_model()
 
         ! Allocate memory
+        ! NOTE: weight, pb0, Re_trans_T are program-lifetime allocations;
+        ! no s_finalize_bubbles_model or s_finalize_* subroutine exists for this module.
         if (bubbles_euler) then
             @:ALLOCATE(weight(nb), R0(nb))
             if (.not. polytropic) then

src/common/m_model.fpp

@@ -970,6 +970,9 @@ contains
                 end if
             end do
 
+            ! NOTE: gpu_ntrs, gpu_trs_v, gpu_trs_n, gpu_boundary_edge_count, gpu_total_vertices, gpu_boundary_v are program-lifetime
+            ! allocations;
+            ! no s_finalize_* subroutine exists for this module.
             if (max_ntrs > 0) then
                 @:ALLOCATE(gpu_ntrs(1:num_stl_models))
                 @:ALLOCATE(gpu_trs_v(1:3, 1:3, 1:max_ntrs, 1:num_stl_models))

src/common/m_mpi_common.fpp

@@ -1509,7 +1509,12 @@ contains
     impure subroutine s_finalize_mpi_common_module
 
 #ifdef MFC_MPI
+#ifndef __NVCOMPILER_GPU_UNIFIED_MEM
+        @:DEALLOCATE(buff_send, buff_recv)
+#else
+        $:GPU_EXIT_DATA(delete='[buff_send, buff_recv]')
         deallocate (buff_send, buff_recv)
+#endif
 #endif
 
     end subroutine s_finalize_mpi_common_module

src/common/m_variables_conversion.fpp

@@ -1237,6 +1237,9 @@ contains
         if (bubbles_euler) then
             @:DEALLOCATE(bubrs_vc)
         end if
+        if (viscous) then
+            @:DEALLOCATE(Res_vc)
+        end if
 #else
         @:DEALLOCATE(gammas, gs_min, pi_infs, ps_inf, cvs, qvs, qvps, Gs_vc)
         if (bubbles_euler) then

src/post_process/m_start_up.fpp

@@ -875,6 +875,10 @@ contains
 
             Nf = max(Nx, Ny, Nz)
 
+            ! NOTE: data_in, data_out, data_cmplx, data_cmplx_y, data_cmplx_z,
+            ! En_real, En are program-lifetime allocations; no s_finalize_start_up_module exists.
+
+            @:ALLOCATE(data_in(Nx*Nyloc*Nzloc))
             @:ALLOCATE(data_in(Nx*Nyloc*Nzloc))
             @:ALLOCATE(data_out(Nx*Nyloc*Nzloc))
 

src/simulation/m_acoustic_src.fpp

@@ -64,6 +64,10 @@ contains
 
         integer :: i, j  !< generic loop variables
 
+        ! NOTE: loc_acoustic, mass_src, mom_src, E_src, source_spatials, source_spatials_num_points are program-lifetime
+        ! allocations;
+        ! no s_finalize_acoustic_src subroutine exists for this module.
+
         @:ALLOCATE(loc_acoustic(1:3, 1:num_source), mag(1:num_source), dipole(1:num_source), support(1:num_source), &
                    & length(1:num_source), height(1:num_source), wavelength(1:num_source), frequency(1:num_source), &
                    & gauss_sigma_dist(1:num_source), gauss_sigma_time(1:num_source), foc_length(1:num_source), &

src/simulation/m_bubbles_EE.fpp

@@ -32,6 +32,9 @@ contains
 
         integer :: l
 
+        ! NOTE: rs, vs, ps, ms, divu%sf, bub_adv_src, bub_r_src, bub_v_src, bub_p_src, bub_m_src are program-lifetime allocations;
+        ! no s_finalize_bubbles_EE_module subroutine exists.
+
         @:ALLOCATE(rs(1:nb))
         @:ALLOCATE(vs(1:nb))
         @:ALLOCATE(ps(1:nb))

src/simulation/m_qbmm.fpp

@@ -56,6 +56,7 @@ contains
             $:GPU_UPDATE(device='[nterms]')
         #:endif
 
+        ! NOTE: momrhs is a program-lifetime allocation; no s_finalize_* subroutine exists for this module.
         @:ALLOCATE(momrhs(1:3, 0:2, 0:2, 1:nterms, 1:nb))
         momrhs = 0._wp
 
@@ -383,6 +384,7 @@ contains
 
         $:GPU_UPDATE(device='[momrhs]')
 
+        ! NOTE: bubmoms is a program-lifetime allocation; no s_finalize_* subroutine exists for this module.
         @:ALLOCATE(bubmoms(1:nb, 1:nmom))
 
         do j = 1, nmom

src/simulation/m_rhs.fpp

@@ -1840,8 +1840,14 @@ contains
             end do
 
             @:DEALLOCATE(flux_n, flux_src_n, flux_gsrc_n)
-            @:DEALLOCATE(qL_prim)
-            @:DEALLOCATE(qR_prim)
+            do i = 1, num_dims
+                do l = eqn_idx%mom%beg, eqn_idx%mom%end
+                    @:DEALLOCATE(qL_prim(i)%vf(l)%sf)
+                    @:DEALLOCATE(qR_prim(i)%vf(l)%sf)
+                end do
+                @:DEALLOCATE(qL_prim(i)%vf, qR_prim(i)%vf)
+            end do
+            @:DEALLOCATE(qL_prim, qR_prim)
         end if
 
         if (alt_soundspeed) then