Remove gcov coverage-cache test selection (--only-changes) (#1460)

Author: sbryngelson

.github/file-filter.yml

@@ -40,6 +40,3 @@ checkall: &checkall
   - *tests
   - *scripts
   - *yml
-
-cases_py:
-  - 'toolchain/mfc/test/cases.py'

.github/workflows/common/rebuild-cache.sh

@@ -57,10 +57,4 @@ if [ -n "${job_shard:-}" ]; then
     shard_opts="--shard $job_shard"
 fi
 
-# Only prune tests on PRs; master pushes must run the full suite.
-prune_flag=""
-if [ "${GITHUB_EVENT_NAME:-}" = "pull_request" ]; then
-    prune_flag="--only-changes"
-fi
-
-./mfc.sh test -v --max-attempts 3 --no-build $prune_flag -a -j $n_test_threads $rdma_opts $device_opts $build_opts $shard_opts -- -c $job_cluster
+./mfc.sh test -v --max-attempts 3 --no-build -a -j $n_test_threads $rdma_opts $device_opts $build_opts $shard_opts -- -c $job_cluster

.github/workflows/common/test.sh

@@ -6,8 +6,6 @@ on:
   pull_request:
     types: [opened, synchronize, reopened, ready_for_review]
   workflow_dispatch:
-  schedule:
-    - cron: '0 6 * * 1'  # Weekly Monday 6 AM UTC: refresh coverage cache before 7-day expiry
 
 concurrency:
   # PRs: group by branch (new push cancels old). Push to master: unique per SHA (never cancelled).
@@ -55,8 +53,6 @@ jobs:
     runs-on: 'ubuntu-latest'
     outputs:
       checkall: ${{ steps.changes.outputs.checkall }}
-      cases_py: ${{ steps.changes.outputs.cases_py }}
-      dep_changed: ${{ steps.dep-check.outputs.dep_changed }}
     steps:
       - name: Clone
         uses: actions/checkout@v4
@@ -67,95 +63,13 @@ jobs:
         with:
           filters: ".github/file-filter.yml"
 
-      - name: Check for Fortran dependency changes
-        id: dep-check
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          # Detect added/removed use/include statements that change the
-          # Fortran dependency graph, which would make the coverage cache stale.
-          PR_NUMBER="${{ github.event.pull_request.number }}"
-          BEFORE="${{ github.event.before }}"
-          AFTER="${{ github.event.after }}"
-          if [ "${{ github.event_name }}" = "pull_request" ]; then
-            # Default to dep_changed=true if gh pr diff fails (safe fallback).
-            DIFF=$(gh pr diff "$PR_NUMBER" 2>/dev/null) || {
-              echo "gh pr diff failed — defaulting to dep_changed=true for safety."
-              echo "dep_changed=true" >> "$GITHUB_OUTPUT"
-              exit 0
-            }
-          elif [ "${{ github.event_name }}" = "push" ]; then
-            DIFF=$(git diff "$BEFORE".."$AFTER" 2>/dev/null) || {
-              echo "git diff failed for push event — defaulting to dep_changed=true for safety."
-              echo "dep_changed=true" >> "$GITHUB_OUTPUT"
-              exit 0
-            }
-          else
-            DIFF=""
-          fi
-          if echo "$DIFF" | \
-             grep -qE '^[+-][[:space:]]*(use[[:space:],]+[a-zA-Z_]|#:include[[:space:]]|include[[:space:]]+['"'"'"])'; then
-            echo "dep_changed=true" >> "$GITHUB_OUTPUT"
-            echo "Fortran dependency change detected — will rebuild coverage cache."
-          else
-            echo "dep_changed=false" >> "$GITHUB_OUTPUT"
-          fi
-
-  rebuild-cache:
-    name: Rebuild Coverage Cache
-    needs: [lint-gate, file-changes]
-    if: >-
-      github.repository == 'MFlowCode/MFC' &&
-      (
-        (github.event_name == 'pull_request' &&
-         (needs.file-changes.outputs.cases_py == 'true' ||
-          needs.file-changes.outputs.dep_changed == 'true')) ||
-        (github.event_name == 'push' &&
-         (needs.file-changes.outputs.cases_py == 'true' ||
-          needs.file-changes.outputs.dep_changed == 'true')) ||
-        github.event_name == 'workflow_dispatch' ||
-        github.event_name == 'schedule'
-      )
-    timeout-minutes: 240
-    runs-on:
-      group:  phoenix
-      labels: gt
-    steps:
-      - name: Clone
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
-          clean: false
-
-      - name: Rebuild Cache via SLURM
-        run: bash .github/scripts/submit-slurm-job.sh .github/workflows/common/rebuild-cache.sh cpu none phoenix
-
-      - name: Print Logs
-        if:   always()
-        run:  cat rebuild-cache-cpu-none.out
-
-      - name: Upload Cache Artifact
-        uses: actions/upload-artifact@v4
-        with:
-          name: coverage-cache
-          path: toolchain/mfc/test/test_coverage_cache.json.gz
-          retention-days: 1
-
-      - name: Save Coverage Cache
-        uses: actions/cache/save@v4
-        with:
-          path: toolchain/mfc/test/test_coverage_cache.json.gz
-          key: coverage-cache-${{ github.event.pull_request.number || 'master' }}-${{ hashFiles('toolchain/mfc/test/cases.py') }}-${{ github.sha }}
-        continue-on-error: true
-
   github:
     name: ${{ matrix.nvhpc && format('NVHPC {0} ({1})', matrix.nvhpc, matrix.target) || format('Github ({0}, {1}, {2}, {3})', matrix.os, matrix.mpi, matrix.debug, matrix.intel && 'intel' || 'GNU') }}
-    needs: [lint-gate, file-changes, rebuild-cache]
+    needs: [lint-gate, file-changes]
     if: >-
       !cancelled() &&
       needs.lint-gate.result == 'success' &&
       needs.file-changes.result == 'success' &&
-      (needs.rebuild-cache.result == 'success' || needs.rebuild-cache.result == 'skipped') &&
       needs.file-changes.outputs.checkall == 'true'
     strategy:
       matrix:
@@ -236,44 +150,6 @@ jobs:
       - name: Clone
         uses: actions/checkout@v4
 
-      - name: Fetch master for coverage diff
-        run: |
-          git fetch origin master:master --depth=1
-          git fetch --deepen=200
-        continue-on-error: true
-
-      - name: Download Coverage Cache (from rebuild in this run)
-        id: cache-artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: coverage-cache
-          path: toolchain/mfc/test
-        continue-on-error: true
-
-      - name: Restore Coverage Cache (from previous run)
-        if: steps.cache-artifact.outcome != 'success'
-        id: cache-restore
-        uses: actions/cache/restore@v4
-        with:
-          path: toolchain/mfc/test/test_coverage_cache.json.gz
-          key: coverage-cache-${{ github.event.pull_request.number || 'master' }}-${{ hashFiles('toolchain/mfc/test/cases.py') }}-${{ github.sha }}
-          restore-keys: |
-            coverage-cache-${{ github.event.pull_request.number || 'master' }}-
-            coverage-cache-master-
-        continue-on-error: true
-
-      - name: Coverage Cache Status
-        run: |
-          if [ "${{ steps.cache-artifact.outcome }}" = "success" ]; then
-            echo "Coverage cache: loaded from rebuild artifact (this run)"
-          elif [ "${{ steps.cache-restore.outputs.cache-hit }}" = "true" ]; then
-            echo "Coverage cache: restored from actions/cache (previous run)"
-          elif [ -f toolchain/mfc/test/test_coverage_cache.json.gz ]; then
-            echo "Coverage cache: using committed fallback in repo"
-          else
-            echo "Coverage cache: none available — full test suite will run"
-          fi
-
       # ── NVHPC: pull image and start a long-lived container ──────────────
       # Replaces the container: directive so we can free disk space first.
       # Uses "docker run -d ... sleep infinity" + "docker exec" to preserve
@@ -386,11 +262,10 @@ jobs:
       - name: Test
         if:   '!matrix.nvhpc'
         run:  |
-          /bin/bash mfc.sh test -v --max-attempts 3 -j $(nproc) $ONLY_CHANGES $TEST_ALL $TEST_PCT $PRECISION
+          /bin/bash mfc.sh test -v --max-attempts 3 -j $(nproc) $TEST_ALL $TEST_PCT $PRECISION
         env:
           TEST_ALL: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}
           TEST_PCT: ${{ matrix.debug == 'reldebug' && '-% 20' || '' }}
-          ONLY_CHANGES: ${{ github.event_name == 'pull_request' && '--only-changes' || '' }}
           PRECISION: ${{ matrix.precision != '' && format('--{0}', matrix.precision) || '' }}
 
       # ── NVHPC build + test (via docker exec into long-lived container) ──
@@ -427,12 +302,11 @@ jobs:
 
   self:
     name: "${{ matrix.cluster_name }} (${{ matrix.device }}${{ matrix.interface != 'none' && format('-{0}', matrix.interface) || '' }}${{ matrix.shard != '' && format(' [{0}]', matrix.shard) || '' }})"
-    needs: [lint-gate, file-changes, rebuild-cache]
+    needs: [lint-gate, file-changes]
     if: >-
       !cancelled() &&
       needs.lint-gate.result == 'success' &&
       needs.file-changes.result == 'success' &&
-      (needs.rebuild-cache.result == 'success' || needs.rebuild-cache.result == 'skipped') &&
       github.repository == 'MFlowCode/MFC' &&
       needs.file-changes.outputs.checkall == 'true' &&
       github.event.pull_request.draft != true
@@ -524,38 +398,6 @@ jobs:
       - name: Clean stale output files
         run:  rm -f *.out
 
-      - name: Download Coverage Cache (from rebuild in this run)
-        id: cache-artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: coverage-cache
-          path: toolchain/mfc/test
-        continue-on-error: true
-
-      - name: Restore Coverage Cache (from previous run)
-        if: steps.cache-artifact.outcome != 'success'
-        id: cache-restore
-        uses: actions/cache/restore@v4
-        with:
-          path: toolchain/mfc/test/test_coverage_cache.json.gz
-          key: coverage-cache-${{ github.event.pull_request.number || 'master' }}-${{ hashFiles('toolchain/mfc/test/cases.py') }}-${{ github.sha }}
-          restore-keys: |
-            coverage-cache-${{ github.event.pull_request.number || 'master' }}-
-            coverage-cache-master-
-        continue-on-error: true
-
-      - name: Coverage Cache Status
-        run: |
-          if [ "${{ steps.cache-artifact.outcome }}" = "success" ]; then
-            echo "Coverage cache: loaded from rebuild artifact (this run)"
-          elif [ "${{ steps.cache-restore.outputs.cache-hit }}" = "true" ]; then
-            echo "Coverage cache: restored from actions/cache (previous run)"
-          elif [ -f toolchain/mfc/test/test_coverage_cache.json.gz ]; then
-            echo "Coverage cache: using committed fallback in repo"
-          else
-            echo "Coverage cache: none available — full test suite will run"
-          fi
-
       - name: Fetch Dependencies
         if:   matrix.cluster != 'phoenix'
         timeout-minutes: 60

.github/workflows/test.yml

@@ -464,27 +464,6 @@
             type=str,
             default=None,
         ),
-        Argument(
-            name="build-coverage-cache",
-            help="Run all tests with gcov instrumentation to build the file-level coverage cache. Pass --gcov to enable coverage instrumentation in the internal build step.",
-            action=ArgAction.STORE_TRUE,
-            default=False,
-            dest="build_coverage_cache",
-        ),
-        Argument(
-            name="only-changes",
-            help="Only run tests whose covered files overlap with files changed since branching from master (uses file-level gcov coverage cache).",
-            action=ArgAction.STORE_TRUE,
-            default=False,
-            dest="only_changes",
-        ),
-        Argument(
-            name="changes-branch",
-            help="Branch to compare against for --only-changes (default: master).",
-            type=str,
-            default="master",
-            dest="changes_branch",
-        ),
     ],
     mutually_exclusive=[
         MutuallyExclusiveGroup(
@@ -517,17 +496,13 @@
         Example("./mfc.sh test -j 4", "Run with 4 parallel jobs"),
         Example("./mfc.sh test --only 3D", "Run only 3D tests"),
         Example("./mfc.sh test --generate", "Regenerate golden files"),
-        Example("./mfc.sh test --only-changes -j 4", "Run tests affected by changed files"),
-        Example("./mfc.sh build --gcov -j 8 && ./mfc.sh test --build-coverage-cache", "One-time: build file-coverage cache"),
     ],
     key_options=[
         ("-j, --jobs N", "Number of parallel test jobs"),
         ("-o, --only PROP", "Run tests matching property"),
         ("-f, --from UUID", "Start from specific test"),
         ("--generate", "Generate/update golden files"),
         ("--no-build", "Skip rebuilding MFC"),
-        ("--build-coverage-cache", "Build file-level gcov coverage cache (one-time)"),
-        ("--only-changes", "Run tests affected by changed files (requires cache)"),
     ],
 )