Skip to content

Commit 67fb5eb

Browse files
sbryngelsonclaude
andcommitted
Fix CI: quote Command forward ref for Python <3.14, revert benchmark.py validation
The `from __future__ import annotations` removal broke pylint on Python 3.10-3.13 because `List[Command]` is a forward reference within the Command dataclass. Quoting it as `List["Command"]` fixes the issue. The scaling benchmark.py requires CLI arguments and cannot be validated as a standalone case file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 15a4a9a commit 67fb5eb

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/lint-toolchain.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
run: |
4545
failed=0
4646
passed=0
47-
for case in examples/*/case.py examples/*/benchmark.py; do
47+
for case in examples/*/case.py; do
4848
[ -f "$case" ] || continue
4949
output=$(./mfc.sh validate "$case" 2>&1)
5050
if [ $? -eq 0 ]; then

toolchain/mfc/cli/schema.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ class Command: # pylint: disable=too-many-instance-attributes
129129
include_common: List[str] = field(default_factory=list) # e.g., ["targets", "jobs"]
130130

131131
# Subcommands (for nested commands like "packer pack")
132-
subcommands: List[Command] = field(default_factory=list)
132+
subcommands: List["Command"] = field(default_factory=list)
133133

134134
# Documentation
135135
description: Optional[str] = None # Long description for docs

0 commit comments

Comments
 (0)