Make common validation policies explicit

Author: sbryngelson

src/common/m_checker_common.fpp

@@ -20,33 +20,33 @@ module m_checker_common
 contains
 
     !> Checks compatibility of parameters in the input file. Used by all three stages
-    impure subroutine s_check_inputs_common
+    impure subroutine s_check_inputs_common(check_total_cells, n_global)
 
-#ifndef MFC_SIMULATION
-        call s_check_total_cells
-#endif
+        logical, intent(in)         :: check_total_cells
+        integer(kind=8), intent(in) :: n_global
+
+        if (check_total_cells) call s_check_total_cells(n_global)
         #:if USING_AMD
             call s_check_amd
         #:endif
 
     end subroutine s_check_inputs_common
 
-#ifndef MFC_SIMULATION
     !> Verify that the total number of grid cells meets the minimum required by the number of dimensions and MPI ranks.
-    impure subroutine s_check_total_cells
+    impure subroutine s_check_total_cells(n_global)
 
-        character(len=18) :: numStr  !< for int to string conversion
-        integer(kind=8)   :: min_cells
+        character(len=18)           :: numStr  !< for int to string conversion
+        integer(kind=8)             :: min_cells
+        integer(kind=8), intent(in) :: n_global
 
         min_cells = int(2, kind=8)**int(min(1, m) + min(1, n) + min(1, p), kind=8)*int(num_procs, kind=8)
         call s_int_to_str(2**(min(1, m) + min(1, n) + min(1, p))*num_procs, numStr)
 
-        @:PROHIBIT(nGlobal < min_cells, &
+        @:PROHIBIT(n_global < min_cells, &
                    & "Total number of cells must be at least (2^[number of dimensions])*num_procs, " // "which is currently " &
                    & // trim(numStr))
 
     end subroutine s_check_total_cells
-#endif
 
     !> Check that simulation parameters stay within AMD GPU compiler limits when case optimization is disabled.
     impure subroutine s_check_amd
@@ -59,6 +59,4 @@ contains
 
     end subroutine s_check_amd
 
-#ifndef MFC_POST_PROCESS
-#endif
 end module m_checker_common

src/common/m_finite_differences.fpp

@@ -38,11 +38,6 @@ contains
             lE = q
         end if
 
-#ifdef MFC_POST_PROCESS
-        if (allocated(fd_coeff_s)) deallocate (fd_coeff_s)
-        allocate (fd_coeff_s(-fd_number_in:fd_number_in,lB:lE))
-#endif
-
         ! Computing the 1st order finite-difference coefficients
         if (fd_order_in == 1) then
             do i = lB, lE

src/post_process/m_start_up.fpp

@@ -120,7 +120,7 @@ contains
             call s_mpi_abort('Unsupported choice for the value of ' // 'case_dir. Exiting.')
         end if
 
-        call s_check_inputs_common()
+        call s_check_inputs_common(check_total_cells=.true., n_global=nGlobal)
         call s_check_inputs()
 
     end subroutine s_check_input_file

src/pre_process/m_start_up.fpp

@@ -128,7 +128,7 @@ contains
             call s_mpi_abort('Unsupported choice for the value of case_dir.' // 'Exiting.')
         end if
 
-        call s_check_inputs_common()
+        call s_check_inputs_common(check_total_cells=.true., n_global=nGlobal)
         call s_check_inputs()
 
         call s_check_patches()

src/simulation/m_start_up.fpp

@@ -144,7 +144,7 @@ contains
             call s_mpi_abort(trim(file_path) // ' is missing. Exiting.')
         end if
 
-        call s_check_inputs_common()
+        call s_check_inputs_common(check_total_cells=.false., n_global=0_8)
         call s_check_inputs()
 
     end subroutine s_check_input_file