fix: gate all CCE IPA workarounds on GITHUB_ACTIONS; GPU per-file, CPU whole-target

Author: Spencer Bryngelson

CMakeLists.txt

@@ -748,16 +748,17 @@ if (MFC_SIMULATION)
     MFC_SETUP_TARGET(TARGET  simulation
                      SOURCES "${simulation_SRCs}"
                      MPI FFTW OpenACC OpenMP)
-    # CCE 19.0.0 optcg ICE: two distinct crashes triggered by IPA inlining:
+    # CCE 19.0.0 optcg ICE on GitHub Actions runners: IPA inlining triggers two
+    # distinct crashes in optcg:
     #   m_bubbles_EL:  castIsValid assertion (InstCombine/foldIntegerTypedPHI)
     #   m_phase_change, m_mpi_common, m_start_up: bring_routine_resident SIGSEGV
-    # Both crash locally and in CI on GPU builds. Apply -Oipa0 per-file
-    # unconditionally to the known crash sites (IPA cross-file inlining triggers
-    # the ICE; per-file disabling prevents it without affecting other files).
-    # CPU-only builds in CI additionally disable IPA for the whole target
-    # (safe — no GPU device-call requirements, and the crash is nondeterministic
-    # so any file can become the crash site). See PR #1286.
-    if (CMAKE_Fortran_COMPILER_ID STREQUAL "Cray")
+    # GPU builds: apply -Oipa0 per-file to known crash sites. Whole-target
+    # -Oipa0 is not safe for GPU builds — it breaks cross-file !$acc routine /
+    # !DIR$ INLINEALWAYS device-call registration, causing runtime aborts.
+    # CPU builds: disable IPA for the whole target (safe — no GPU requirements,
+    # and the crash is nondeterministic so any file can become the crash site).
+    # See PR #1286.
+    if (CMAKE_Fortran_COMPILER_ID STREQUAL "Cray" AND DEFINED ENV{GITHUB_ACTIONS})
         if (MFC_OpenACC OR MFC_OpenMP)
             set_source_files_properties(
                 "${CMAKE_BINARY_DIR}/fypp/simulation/m_bubbles_EL.fpp.f90"
@@ -766,7 +767,7 @@ if (MFC_SIMULATION)
                 "${CMAKE_BINARY_DIR}/fypp/simulation/m_start_up.fpp.f90"
                 PROPERTIES COMPILE_OPTIONS "-Oipa0"
             )
-        elseif (DEFINED ENV{GITHUB_ACTIONS})
+        else()
             target_compile_options(simulation PRIVATE -Oipa0)
         endif()
     endif()