refactor: introduce bc_dir_t type, strip BC payload from int_bounds_info

Author: sbryngelson

src/common/m_derived_types.fpp

@@ -103,27 +103,28 @@ module m_derived_types
         integer :: end
     end type idx_bounds_info
 
-    !> Integer bounds for variables
+    !> Integer beg/end bounds pair for loop index ranges and domain extents.
     type int_bounds_info
-        integer                             :: beg
-        integer                             :: end
-        real(wp)                            :: vb1
-        real(wp)                            :: vb2
-        real(wp)                            :: vb3
-        real(wp)                            :: ve1
-        real(wp)                            :: ve2
-        real(wp)                            :: ve3
+        integer :: beg
+        integer :: end
+    end type int_bounds_info
+
+    !> Boundary condition parameters for one coordinate direction (beg/end faces + face data).
+    type bc_dir_t
+        integer                             :: beg, end
+        real(wp)                            :: vb1, vb2, vb3
+        real(wp)                            :: ve1, ve2, ve3
         real(wp)                            :: pres_in, pres_out
         real(wp), dimension(3)              :: vel_in, vel_out
         real(wp), dimension(num_fluids_max) :: alpha_rho_in, alpha_in
         logical                             :: grcbc_in, grcbc_out, grcbc_vel_out
         logical                             :: isothermal_in, isothermal_out
         real(wp)                            :: Twall_in, Twall_out
-    end type int_bounds_info
+    end type bc_dir_t
 
-    !> Groups the x, y, z boundary condition begin/end codes for passing as a single argument.
+    !> Groups the x, y, z boundary condition structs for passing as a single argument.
     type bc_xyz_info
-        type(int_bounds_info) :: x, y, z
+        type(bc_dir_t) :: x, y, z
     end type bc_xyz_info
 
     !> QBMM moment index mappings - separate from bub beg/end so eqn_idx contains no allocatables.
@@ -137,7 +138,7 @@ module m_derived_types
     end type qbmm_idx_info
 
     !> All conserved-variable equation indices, computed at startup from model_eqns and enabled features.
-    !> Range indices (beg/end) use int_bounds_info; scalar indices are plain integers (0 = inactive).
+    !> Range indices (beg/end) use idx_bounds_info; scalar indices are plain integers (0 = inactive).
     !> Contains no allocatable members - safe for GPU_DECLARE as a single struct.
     type eqn_idx_info
         type(idx_bounds_info) :: cont     !< Partial densities (continuity equations)

src/post_process/m_global_parameters.fpp

@@ -117,7 +117,7 @@ module m_global_parameters
     logical               :: bc_io
     !> @name Boundary conditions in the x-, y- and z-coordinate directions
     !> @{
-    type(int_bounds_info) :: bc_x, bc_y, bc_z
+    type(bc_dir_t) :: bc_x, bc_y, bc_z
     !> @}
 
     integer                            :: shear_num  !< Number of shear stress components

src/pre_process/m_global_parameters.fpp

@@ -86,7 +86,7 @@ module m_global_parameters
 
     ! Cell indices (InDices With BUFFer): includes buffer except in pre_process
     type(int_bounds_info)      :: idwbuff(1:3)
-    type(int_bounds_info)      :: bc_x, bc_y, bc_z       !< Boundary conditions in the x-, y- and z-coordinate directions
+    type(bc_dir_t)             :: bc_x, bc_y, bc_z       !< Boundary conditions in the x-, y- and z-coordinate directions
     integer                    :: shear_num              !< Number of shear stress components
     integer, dimension(3)      :: shear_indices          !< Indices of the stress components that represent shear stress
     integer                    :: shear_BC_flip_num      !< Number of shear stress components to reflect for boundary conditions

src/simulation/m_global_parameters.fpp

@@ -202,12 +202,12 @@ module m_global_parameters
     logical :: bc_io
     !> @name Boundary conditions (BC) in the x-, y- and z-directions, respectively
     !> @{
-    type(int_bounds_info) :: bc_x, bc_y, bc_z
+    type(bc_dir_t) :: bc_x, bc_y, bc_z
     !> @}
     !> @name Original boundary conditions preserved for immersed boundary code
     !> (bc_x/y/z get overwritten with MPI neighbor ranks during decomposition)
     !> @{
-    type(int_bounds_info) :: ib_bc_x, ib_bc_y, ib_bc_z
+    type(bc_dir_t) :: ib_bc_x, ib_bc_y, ib_bc_z
     !> @}
 #if defined(MFC_OpenACC)
     $:GPU_DECLARE(create='[bc_x%vb1, bc_x%vb2, bc_x%vb3, bc_x%ve1, bc_x%ve2, bc_x%ve3]')

src/simulation/m_weno.fpp

@@ -182,7 +182,7 @@ contains
         type(int_bounds_info), intent(in) :: is
         integer                           :: s
         real(wp), pointer, dimension(:)   :: s_cb => null()  !< Cell-boundary locations in the s-direction
-        type(int_bounds_info)             :: bc_s            !< Boundary conditions (BC) in the s-direction
+        type(bc_dir_t)                    :: bc_s            !< Boundary conditions (BC) in the s-direction
         integer                           :: i               !< Generic loop iterator
         real(wp)                          :: w(1:8)          !< Intermediate var for ideal weights: s_cb across overall stencil
         real(wp)                          :: ys(1:4)         !< Intermediate var for poly & beta: diff(s_cb) across sub-stencil