Skip to content

Commit 8ab8894

Browse files
committed
fix: update advection_muscl example to model_eqns=2 (THINC incompatible with model_eqns=3)
THINC/MTHINC only reconstructs partial densities and volume fractions at faces. For model_eqns=3 (6-equation), the per-fluid internal energies (eqn_idx%int_en) are left unreconstructed after THINC compression, making the face states thermodynamically inconsistent. The 5-equation model (model_eqns=2) has no per-fluid internal energy equations so this inconsistency cannot occur. Regenerate golden file for test 10DE58AA.
1 parent 6051590 commit 8ab8894

3 files changed

Lines changed: 81 additions & 109 deletions

File tree

examples/2D_advection_muscl/case.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"t_step_save": 100,
2222
# Simulation Algorithm Parameters
2323
"num_patches": 2,
24-
"model_eqns": 3,
24+
"model_eqns": 2,
2525
"alt_soundspeed": "F",
2626
"num_fluids": 2,
2727
"mpp_lim": "T",

tests/10DE58AA/golden-metadata.txt

Lines changed: 71 additions & 95 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)