fix: extend CCE 19.0.0 -Oipa0 workaround to full targets (not per-file)

Per-file set_source_files_properties is insufficient because the IPA pass
inlines across all files in the target — any file can become the crash site.
Apply -Oipa0 target-wide for pre_process and simulation (Cray, not OpenMP).
OpenMP excluded: thermochem requires IPA for !DIR$ INLINEALWAYS device calls.

Author: Spencer Bryngelson

CMakeLists.txt

@@ -734,34 +734,27 @@ if (MFC_PRE_PROCESS)
                      MPI)
     if(CMAKE_Fortran_COMPILER_ID STREQUAL "Cray")
         target_compile_options(pre_process PRIVATE -hfp0)
-        # CCE 19.0.0 IPA workaround: m_mpi_common triggers bring_routine_resident
-        # SIGSEGV in optcg during ipa_processing. See simulation block below for details.
-        set_source_files_properties(
-            "${CMAKE_BINARY_DIR}/fypp/pre_process/m_mpi_common.fpp.f90"
-            PROPERTIES COMPILE_OPTIONS "-Oipa0"
-        )
+        # CCE 19.0.0 IPA ICE: bring_routine_resident SIGSEGV in optcg during
+        # ipa_processing. The crash is nondeterministic and can hit any file via
+        # cross-file inlining, so disable IPA for the whole target. Safe for
+        # pre_process (CPU-only, no thermochem IPA requirements).
+        target_compile_options(pre_process PRIVATE -Oipa0)
     endif()
 endif()
 
 if (MFC_SIMULATION)
     MFC_SETUP_TARGET(TARGET  simulation
                      SOURCES "${simulation_SRCs}"
                      MPI FFTW OpenACC OpenMP)
-    # CCE 19.0.0 IPA workaround: disable interprocedural analysis for files
-    # that trigger compiler crashes during IPA:
-    #   m_bubbles_EL: castIsValid assertion (InstCombine/foldIntegerTypedPHI)
-    #   m_phase_change, m_mpi_common: bring_routine_resident SIGSEGV
+    # CCE 19.0.0 IPA ICE: bring_routine_resident SIGSEGV in optcg during
+    # ipa_processing. The crash is nondeterministic — IPA inlines across all
+    # files in the target, so any file can become the crash site. Per-file
+    # -Oipa0 via set_source_files_properties is insufficient.
     # Not applied to Cray+OpenMP because thermochem uses !DIR$ INLINEALWAYS,
     # which requires IPA to inline device calls. On OpenACC the pyrometheus
     # patch emits !$acc routine seq instead (no IPA needed). See PR #1286.
     if (CMAKE_Fortran_COMPILER_ID STREQUAL "Cray" AND NOT MFC_OpenMP)
-        set_source_files_properties(
-            "${CMAKE_BINARY_DIR}/fypp/simulation/m_bubbles_EL.fpp.f90"
-            "${CMAKE_BINARY_DIR}/fypp/simulation/m_phase_change.fpp.f90"
-            "${CMAKE_BINARY_DIR}/fypp/simulation/m_mpi_common.fpp.f90"
-            "${CMAKE_BINARY_DIR}/fypp/simulation/m_start_up.fpp.f90"
-            PROPERTIES COMPILE_OPTIONS "-Oipa0"
-        )
+        target_compile_options(simulation PRIVATE -Oipa0)
     endif()
 endif()