fix(test): key coverage_key on full params, not mods (soundness)

Author: sbryngelson

toolchain/mfc/test/case.py

@@ -165,7 +165,6 @@ def __init__(self, trace: str, mods: dict, ppn: int = None, override_tol: float
         self.restart_check = restart_check
         self.kind = kind
         self.convergence_spec = convergence_spec
-        self.mods = mods
         merge = {**BASE_CFG.copy(), **mods}
         merge = {key: val for key, val in merge.items() if val is not None}
         super().__init__(merge)
@@ -250,7 +249,7 @@ def get_uuid(self) -> str:
     def coverage_key(self) -> str:
         from .coverage import param_hash
 
-        return param_hash(self.mods)
+        return param_hash(self.params)
 
     def get_dirpath(self):
         return os.path.join(common.MFC_TEST_DIR, self.get_uuid())

toolchain/mfc/test/test_coverage_unit.py

@@ -123,11 +123,19 @@ def test_rung6_and_7_overlap_selects_subset():
     assert [c.coverage_key() for c in skip] == ["miss"]
 
 
-def test_case_coverage_key_matches_param_hash():
+def test_case_coverage_key_uses_full_params():
     from mfc.test.case import TestCase
 
     tc = TestCase("1D -> Foo", {"m": 100, "weno_order": 5})
-    assert tc.coverage_key() == param_hash({"m": 100, "weno_order": 5})
+    assert tc.coverage_key() == param_hash(tc.params)
+
+
+def test_case_coverage_key_changes_with_params():
+    from mfc.test.case import TestCase
+
+    a = TestCase("1D -> Foo", {"weno_order": 5})
+    b = TestCase("1D -> Foo", {"weno_order": 3})
+    assert a.coverage_key() != b.coverage_key()
 
 
 def test_case_coverage_key_ignores_trace():