Skip to content

Commit a67bc37

Browse files
sbryngelsonclaude
andcommitted
Remove legacy viz scripts and viz_legacy module; fix lint for viz extras
- Delete analyze.py, export.py (nD_perfect_reactor) and viz.py (1D shocktube examples) which all used mfc.viz_legacy - Delete toolchain/mfc/viz_legacy.py (superseded by ./mfc.sh viz) - Update nD_perfect_reactor/README.md to remove analyze.py invocation - lint.sh: install mfc[viz] optional extras before running pylint and test_viz so optional imports (imageio, h5py, textual) resolve cleanly - tui.py: suppress R0903 on MFCPlot (inherits many methods from parent) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 7d04f9a commit a67bc37

8 files changed

Lines changed: 4 additions & 502 deletions

File tree

examples/1D_inert_shocktube/viz.py

Lines changed: 0 additions & 80 deletions
This file was deleted.

examples/1D_reactive_shocktube/viz.py

Lines changed: 0 additions & 80 deletions
This file was deleted.

examples/nD_perfect_reactor/README.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,4 @@
33
Reference:
44
> G. B. Skinner and G. H. Ringrose, “Ignition Delays of a Hydrogen—Oxygen—Argon Mixture at Relatively Low Temperatures”, J. Chem. Phys., vol. 42, no. 6, pp. 2190–2192, Mar. 1965. Accessed: Oct. 13, 2024.
55
6-
```bash
7-
$ python3 analyze.py
8-
Induction Times ([OH] >= 1e-6):
9-
+ Skinner et al.: 5.200e-05 s
10-
+ Cantera: 5.130e-05 s
11-
+ (Che)MFC: 5.130e-05 s
12-
```
13-
146
<img src="result.png" height="MAX_HEIGHT"/>

examples/nD_perfect_reactor/analyze.py

Lines changed: 0 additions & 107 deletions
This file was deleted.

examples/nD_perfect_reactor/export.py

Lines changed: 0 additions & 76 deletions
This file was deleted.

toolchain/bootstrap/lint.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ for arg in "$@"; do
1212
esac
1313
done
1414

15+
log "(venv) Installing$MAGENTA viz$COLOR_RESET optional dependencies for linting..."
16+
uv pip install -q "$(pwd)/toolchain[viz]" 2>/dev/null || pip install -q "$(pwd)/toolchain[viz]"
17+
1518
log "(venv) Running$MAGENTA pylint$COLOR_RESET on$MAGENTA MFC$COLOR_RESET's $MAGENTA""toolchain$COLOR_RESET."
1619

1720
pylint -d R1722,W0718,C0301,C0116,C0115,C0114,C0410,W0622,W0640,C0103,W1309,C0411,W1514,R0401,W0511,C0321,C3001,R0801,R0911,R0912 "$(pwd)/toolchain/"

toolchain/mfc/viz/tui.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
# Plot widget
5757
# ---------------------------------------------------------------------------
5858

59-
class MFCPlot(PlotextPlot): # pylint: disable=too-many-instance-attributes
59+
class MFCPlot(PlotextPlot): # pylint: disable=too-many-instance-attributes,too-few-public-methods
6060
"""Plotext plot widget. Caller sets ._x_cc / ._y_cc / ._data / ._ndim /
6161
._varname / ._step before calling .refresh()."""
6262

0 commit comments

Comments
 (0)