fix(review): 6 issues from PR self-review

- completion_gen: fix zsh --gpu completion ('acc:mp' -> 'acc mp')
- case_validator: move recon_type prohibit to check_parameter_types (was duplicated 4x)
- CMakeLists: remove nonexistent namelist_targets.py stamp watch; add registry.py + schema.py
- fortran_gen: guard nl_with_cont[-1] against empty normal list
- docs_gen: use .get() for REGISTRY lookups to avoid KeyError on unknown params

Author: sbryngelson

CMakeLists.txt

@@ -468,8 +468,9 @@ set(_mfc_gen_stamp "${CMAKE_BINARY_DIR}/mfc_params_gen.stamp")
 set(_mfc_gen_inputs
     "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/generators/cmake_gen.py"
     "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/generators/fortran_gen.py"
-    "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/namelist_targets.py"
     "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/definitions.py"
+    "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/registry.py"
+    "${CMAKE_CURRENT_SOURCE_DIR}/toolchain/mfc/params/schema.py"
 )
 set(_mfc_needs_regen FALSE)
 if(NOT EXISTS "${_mfc_gen_stamp}")

toolchain/mfc/case_validator.py

@@ -260,10 +260,7 @@ def _check_order_fits_grid(self, order: int, param_name: str) -> None:
         self.prohibit(p > 0 and p + 1 < order, f"For 3D: p must be at least {param_name} - 1 (= {order - 1})")
 
     def _get_recon_type(self) -> int:
-        """Return recon_type after validating it is 1 (WENO) or 2 (MUSCL)."""
-        recon_type = self.get("recon_type", 1)
-        self.prohibit(recon_type not in [1, 2], "recon_type must be 1 (WENO) or 2 (MUSCL)")
-        return recon_type
+        return self.get("recon_type", 1)
 
     def check_parameter_types(self):
         """Validate parameter types before other checks.
@@ -280,6 +277,8 @@ def check_parameter_types(self):
             if param in self.params:  # Only validate params that are set
                 self._validate_logical(param)
 
+        self.prohibit(self.get("recon_type", 1) not in [1, 2], "recon_type must be 1 (WENO) or 2 (MUSCL)")
+
         # Required domain parameters when m > 0
         m = self.get("m")
         if m is not None and m > 0:

toolchain/mfc/cli/completion_gen.py

@@ -28,7 +28,7 @@ def _mfc_config_zsh_flags() -> List[str]:
     from ..state import MFCConfig, gpuConfigOptions
 
     specs = []
-    modes = ":".join(e.value for e in gpuConfigOptions if e.value != gpuConfigOptions.NONE.value)
+    modes = " ".join(e.value for e in gpuConfigOptions if e.value != gpuConfigOptions.NONE.value)
     for f in dataclasses.fields(MFCConfig):
         cli = f.name.replace("_", "-")
         label = cli.replace("-", " ").title()

toolchain/mfc/params/generators/docs_gen.py

@@ -463,8 +463,8 @@ def generate_parameter_docs() -> str:
             pattern_has_symbols = False
             for _pattern, examples in patterns.items():
                 for ex in examples:
-                    p = REGISTRY.all_params[ex]
-                    if p.constraints or ex in by_trigger or ex in by_param:
+                    p = REGISTRY.all_params.get(ex)
+                    if p and (p.constraints or ex in by_trigger or ex in by_param):
                         pattern_has_constraints = True
                     if get_math_symbol(ex):
                         pattern_has_symbols = True
@@ -484,7 +484,8 @@ def generate_parameter_docs() -> str:
 
             for pattern, examples in sorted(patterns.items()):
                 example = examples[0]
-                desc = REGISTRY.all_params[example].description
+                _ep = REGISTRY.all_params.get(example)
+                desc = _ep.description if _ep else ""
                 # Truncate long descriptions
                 if len(desc) > 60:
                     desc = desc[:57] + "..."
@@ -497,8 +498,9 @@ def generate_parameter_docs() -> str:
                     sym = get_math_symbol(example)
                     row += f" | {sym}"
                 if pattern_has_constraints:
-                    p = REGISTRY.all_params[example]
-                    row += f" | {_format_constraints_cell(example, p, by_trigger, by_param)}"
+                    p = REGISTRY.all_params.get(example)
+                    if p:
+                        row += f" | {_format_constraints_cell(example, p, by_trigger, by_param)}"
                 lines.append(row + " |")
 
             lines.append("")

toolchain/mfc/params/generators/fortran_gen.py

@@ -87,7 +87,7 @@ def generate_namelist_fpp(target: str) -> str:
     normal = [v for v in all_vars if v not in CASE_OPT_PARAMS]
     opt = sorted(v for v in CASE_OPT_PARAMS if v in NAMELIST_VARS and "sim" in NAMELIST_VARS[v])
     nl_lines = _pack_namelist(normal, _FIRST_PREFIX, _CONT_PREFIX, _MAX_LINE)
-    if opt:
+    if opt and nl_lines:
         opt_lines = _pack_namelist(opt, _CONT_PREFIX, _CONT2_PREFIX, _MAX_LINE)
         nl_with_cont = nl_lines[:]
         nl_with_cont[-1] += ", &"