Skip to content

Commit b989646

Browse files
Documented implementation progress
Updated implementation notes and testing strategy in CONTRIBUTING.md.
1 parent 4e1b5fa commit b989646

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,13 @@ Implementation:
2828
- ast_analyzer.py
2929

3030
4. I will verify my approach works by calling flag() instead of get() in line 1487 of case_validator.py. If the analyzer correctly returns a value instead of blank, it successfully recognized the flag() function. I will also test the flag() method itself to ensure it correctly returns true or false.
31+
32+
# Implementation Notes
33+
34+
Implementation Progress: I fixed _build_local_param_map() in ast_analyzer.py to recognize flag() method and added a flag() helper method in case_validator.py.
35+
36+
Challenges Faced: The main challenge was understanding the codebase.
37+
38+
Testing Strategy: I tested the flag method itself to ensure it correctly return a bool for all possible params (T, F, null). I also test to see that the old broken code fails and the new code works.
39+
40+
Branch Link: https://github.com/mansibrahman03/MFlowCode/tree/main

0 commit comments

Comments
 (0)