feat(amr): support acoustic sources with a static block - source acts on the coarse grid (fine advance skips coarse-index spatials), startup abort on support/block overlap; golden 65C375B4

Author: sbryngelson

src/simulation/m_acoustic_src.fpp

@@ -455,6 +455,25 @@ contains
                 call s_mpi_abort('Fatal Error: Inconsistent allocation of source_spatials')
             end if
 
+            ! The AMR fine advance skips the acoustic source (the spatials above are coarse-grid
+            ! cell indices), so a static fine block overlapping the support would silently drop
+            ! the source inside the block - abort instead. Emitted waves still enter the block
+            ! through the coarse/fine coupling; only the support itself must stay coarse-only.
+            if (amr) then
+                do j = 1, count
+                    if (int(source_spatials(ai)%coord(1, &
+                        & j)) + start_idx(1) >= amr_block_beg(1) .and. int(source_spatials(ai)%coord(1, &
+                        & j)) + start_idx(1) <= amr_block_end(1) .and. (n_glb == 0 .or. (int(source_spatials(ai)%coord(2, &
+                        & j)) + start_idx(2) >= amr_block_beg(2) .and. int(source_spatials(ai)%coord(2, &
+                        & j)) + start_idx(2) <= amr_block_end(2))) .and. (p_glb == 0 .or. (int(source_spatials(ai)%coord(3, &
+                        & j)) + start_idx(3) >= amr_block_beg(3) .and. int(source_spatials(ai)%coord(3, &
+                        & j)) + start_idx(3) <= amr_block_end(3)))) then
+                        call s_mpi_abort('amr with acoustic_source: the source support overlaps the static fine block; ' &
+                                         & // 'the source acts on the coarse grid only - move the source or the block apart')
+                    end if
+                end do
+            end if
+
             if (count > 0) then
                 $:GPU_UPDATE(device='[source_spatials(ai)%coord]')
                 $:GPU_UPDATE(device='[source_spatials(ai)%val]')

src/simulation/m_amr.fpp

@@ -74,6 +74,7 @@ module m_amr
     !> Saved coarse-level global state for swap/restore
     integer               :: sw_m, sw_n, sw_p
     type(int_bounds_info) :: sw_idwint(3), sw_idwbuff(3)
+    logical               :: sw_acoustic_source
     real(wp), allocatable :: sw_x_cb(:), sw_x_cc(:), sw_dx(:)
     real(wp), allocatable :: sw_y_cb(:), sw_y_cc(:), sw_dy(:)
     real(wp), allocatable :: sw_z_cb(:), sw_z_cc(:), sw_dz(:)
@@ -800,6 +801,10 @@ contains
 
         sw_m = m; sw_n = n; sw_p = p
         sw_idwint = idwint; sw_idwbuff = idwbuff
+        ! the acoustic source's precomputed spatials are coarse-grid cell indices: applying them on
+        ! the fine block would inject at wrong cells (or out of bounds). The support is guaranteed
+        ! not to overlap the block (checked at startup), so the fine RHS correctly skips the source.
+        sw_acoustic_source = acoustic_source; acoustic_source = .false.
         m = amr_slots(amr_cur)%m; n = amr_slots(amr_cur)%n; p = amr_slots(amr_cur)%p
         idwint(1)%beg = 0; idwint(1)%end = m
         idwint(2)%beg = 0; idwint(2)%end = n
@@ -872,6 +877,7 @@ contains
 
         m = sw_m; n = sw_n; p = sw_p
         idwint = sw_idwint; idwbuff = sw_idwbuff
+        acoustic_source = sw_acoustic_source
         ! restore full coarse coords from bounce buffers
         x_cb = sw_x_cb; x_cc = sw_x_cc; dx = sw_dx
         if (n_glb > 0) then; y_cb = sw_y_cb; y_cc = sw_y_cc; dy = sw_dy; end if

src/simulation/m_checker.fpp

@@ -116,8 +116,11 @@ contains
             @:PROHIBIT(active_box, "amr is incompatible with active_box (unvalidated combination)")
             @:PROHIBIT(hybrid_weno, "amr is incompatible with hybrid_weno (unvalidated combination)")
             @:PROHIBIT(hybrid_riemann, "amr is incompatible with hybrid_riemann (unvalidated combination)")
-            @:PROHIBIT(acoustic_source, &
-                       & "amr is incompatible with acoustic_source (dt-dependent RHS source; unvalidated with the fine-level advance)")
+            ! acoustic sources act on the coarse grid only (their spatial support is precomputed as
+            ! coarse cell indices); a startup check aborts if the support overlaps the static block.
+            ! Dynamic regrid stays gated: new blocks could appear anywhere, including on the source.
+            @:PROHIBIT(acoustic_source .and. amr_regrid_int > 0, &
+                       & "amr with acoustic_source requires a static block (amr_regrid_int = 0): the source support is precomputed on the coarse grid and must not overlap a fine block")
             @:PROHIBIT(any(amr_block_beg(1:num_dims) < 0), "amr_block_beg must be >= 0")
             @:PROHIBIT(amr_block_end(1) > m_glb .or. (num_dims >= 2 .and. amr_block_end(2) > n_glb) .or. (num_dims >= 3 &
                        & .and. amr_block_end(3) > p_glb), "amr_block_end must be <= global cell max per axis")