Skip to content

Commit c188d37

Browse files
Added PR notes
1 parent 4cd78c2 commit c188d37

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,13 @@ Challenges Faced: The main challenge was understanding the codebase.
3838
Testing Strategy: I tested the flag method itself to ensure it correctly return a bool for all possible params (T, F, null). I also test to see that the old broken code fails and the new code works.
3939

4040
Branch Link: https://github.com/mansibrahman03/MFlowCode/tree/main
41+
42+
# PR
43+
44+
PR Link: [Direct link to your submitted pull request](https://github.com/MFlowCode/MFC/pull/1622)
45+
46+
PR Description: I added a flag() method in toolchain/mfc/case_validator.py that functions to replace the verbose idiom "self.get(x,F)==T" repeated in 134 places across the file. I also updated ast_analyzer.py to recognize calls made to flag().
47+
48+
Maintainer Feedback: I am currently waiting for maintainer to respond.
49+
50+
Status: Awaiting review

0 commit comments

Comments
 (0)