jwl: keep Rocflu closure only; remove modes 0, 1, and 2

Remove the isobaric (mode 0), Kuhl & Khasainov (mode 1), and p-T
equilibrium (mode 2) JWL mixture closures. Only the Rocflu
state-interpolated closure (mode 3, Garno/Stanley formulation after
RFLU_ModJWL.F90) is retained. This is the only mode needed by the
macroscale team for the hemispherical blast problem.

Key changes:
- m_jwl.fpp: rewritten to ~300 lines (from ~1330); formulas now match
  RFLU_ModJWL.F90 reference exactly: p = An*C1 + Bn*C2 + omega*rho*e,
  T from cv-based inversion, 7-term analytic c2. C1-smooth cubic
  Hermite Y-blend over [0.95,1.0] replaces hard cutoff at Y=0.99.
- m_checker_common.fpp: jwl_mix_type must be 3; single-fluid JWL
  cases (Y=1 always) are permitted without a second air fluid.
- m_variables_conversion.fpp: simplified to single s_jwl_mix_sound_speed
  dispatch call.
- toolchain: jwl_mix_type choices restricted to [3]; description updated;
  test case reduced to single Rocflu regression; golden files regenerated.
- examples: added jwl_mix_type=3 and fluid_pp%cv where required.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: 2 people

.typos.toml

@@ -31,4 +31,4 @@ tru = "tru"           # typo for "true" in "when_tru" - tests dependency keys
 PNGs = "PNGs"
 
 [files]
-extend-exclude = ["docs/documentation/references*", "docs/references.bib", "tests/", "toolchain/cce_simulation_workgroup_256.sh", "build-docs/", "build/", "build_test/", "fp-stability-logs/"]
+extend-exclude = ["docs/documentation/references*", "docs/references.bib", "tests/", "toolchain/cce_simulation_workgroup_256.sh", "build-docs/", "build/", "build_test/", "fp-stability-logs/", "validation/"]

CLAUDE.md

@@ -133,7 +133,9 @@ there over restating it. Most relevant: `contributing.md` (standards, architectu
 general pitfalls), `gpuParallelization.md` (GPU macro API), `testing.md` (test system),
 `case.md` (case parameters, analytic ICs). MFC-specific traps with silent failure modes
 live in `.claude/rules/common-pitfalls.md` — read it before touching indexing, GPU loops,
-parameters, or tests.
+parameters, or tests. JWL/multiphase physics domain knowledge (EOS hierarchy, mixture
+sound speed reasoning, Kuhl kpw model, validation methodology) lives in
+`.claude/rules/senior-cfd-physics.md`.
 
 ## Code Review Priorities
 

README-JWL-EOS.md

@@ -19,14 +19,14 @@ The cold-curve pressure is evaluated through a shared helper so pressure recover
 The `jwl_mix_type` selector is available only for five-equation JWL/ideal-gas mixtures with one JWL products fluid and one non-JWL ideal-gas fluid.
 
 - `0`, `isobaric`: closed-form mechanical-equilibrium closure. This is the default validation path.
-- `1`, `kuhl`: Kuhl/Khasainov temperature-form additive closure. It requires positive `cv` on both products and air.
-- `2`, `ptequil`: pressure-temperature equilibrium closure. It solves a bounded scalar root for the products volume fraction and is substantially more expensive than mode `0`.
-- `3`, `rocflu`: Garno/Rocflu-style single-fluid blend. Its sound speed is evaluated by the Rocflu-specific Gruneisen form rather than by phasic volume fractions.
+- `1`, `kuhl`: the supplied Kuhl/Khasainov piece-wise caloric model and additive pressure `p_air + p_products`.
+- `2`, `ptequil`: the supplied `model_exact.f90` pressure-temperature equilibrium model. MFC eliminates the four unknowns in the reference matrix to a bracketed products-volume-fraction solve while retaining the same pressure, temperature, volume, and energy equations. Air uses the Kuhl caloric table shifted by `jwl_air_e0`; products require positive `cv`.
+- `3`, `rocflu`: the Rocflu single-fluid closure from `modflu/RFLU_ModJWL.F90`. It interpolates the JWL coefficients with specific internal energy and the Gruneisen coefficient and heat capacity with mixture density, with ideal-air and pure-products endpoint branches.
 
 Finite pressure, temperature, energy, and sound-speed floors are applied only after explicit finite checks. NaNs are intentionally preserved so bad states are visible during debugging instead of being converted into plausible-looking floor values.
 
 ## Validation Scope
 
-The exact-reference validation in this branch is scoped to five-equation JWL cases: a 1D pure-JWL shock tube and a compact 3D quasi-1D repeat of the same published Shyue-style Riemann reference. Closure selectability is covered by registered golden tests for `jwl_mix_type = 0, 1, 2, 3`.
+Closure selectability is covered by registered golden tests for `jwl_mix_type = 0, 1, 2, 3`. The mode-3 regression includes a homogeneous 50/50 products-air slab so the Rocflu density and energy interpolation is exercised in addition to its endpoint branches.
 
-The p-T equilibrium mode remains selectable and physically distinct. Its root-find cost is measured by `benchmarks/jwl_closure_modes`; it is not optimized away by the case-optimization gates.
+Mode `3` follows Rocflu's pressure, temperature, and sound-speed formulas, but replaces its case-specific hard-coded air values and explosive energy divisor with the corresponding MFC material inputs. Its inverse energy selects the exact low-, blended-, or high-energy branch of that pressure law; this removes the legacy fallback's pressure/energy round-trip mismatch.

docs/documentation/case.md

@@ -443,7 +443,7 @@ Details of implementation of viscosity in MFC can be found in \cite Coralic15.
 
 - `fluid_pp(i)%%G` is required for `hypoelasticity`.
 
-- `fluid_pp(i)%%eos` selects the equation of state for the $i$-th fluid: [1] stiffened gas (default); [2] Jones-Wilkins-Lee (JWL) for detonation products, supported with `model_eqns = 2` and at most one JWL fluid. A JWL fluid requires `jwl_A`, `jwl_B`, `jwl_R1`, `jwl_R2`, `jwl_omega`, `jwl_rho0`, and `jwl_E0` (the standard JWL coefficients), and `jwl_air_e0`, `jwl_air_rho0`, `jwl_air_gamma` describing the co-existing ideal gas; `jwl_air_gamma` is the stored form \f$\gamma_{\mathrm{air}}-1\f$. The closure used to mix products with the surrounding gas is set globally by `jwl_mix_type`; modes 1 (Kuhl) and 2 (p-T equilibrium) additionally require a positive `cv` on both fluids.
+- `fluid_pp(i)%%eos` selects the equation of state for the $i$-th fluid: [1] stiffened gas (default); [2] Jones-Wilkins-Lee (JWL) for detonation products, supported with `model_eqns = 2` and at most one JWL fluid. A JWL fluid requires `jwl_A`, `jwl_B`, `jwl_R1`, `jwl_R2`, `jwl_omega`, `jwl_rho0`, and `jwl_E0` (the standard JWL coefficients), and `jwl_air_e0`, `jwl_air_rho0`, `jwl_air_gamma` describing the co-existing ideal gas; `jwl_air_gamma` is the stored form \f$\gamma_{\mathrm{air}}-1\f$. The closure used to mix products with the surrounding gas is set globally by `jwl_mix_type`; mode 2 requires positive products `cv`, while mode 3 requires positive products and air `cv`.
 
 > **Stored-form parameters:** The values `gamma`, `pi_inf`, and `Re(1)`/`Re(2)` are **not** the raw physical quantities. MFC expects transformed stored forms:
 > - `gamma` = \f$1/(\gamma-1)\f$, not \f$\gamma\f$ itself
@@ -463,7 +463,7 @@ See @ref equations "Equations" for the mathematical models these parameters cont
 | `bc_[x,y,z]%%vb[1,2,3]`‡   | Real    | Velocity in the (x,1), (y, 2), (z,3) direction applied to `bc_[x,y,z]%%beg` |
 | `bc_[x,y,z]%%ve[1,2,3]`‡   | Real    | Velocity in the (x,1), (y, 2), (z,3) direction applied to `bc_[x,y,z]%%end` |
 | `model_eqns`               | Integer | Multicomponent model: [1] \f$\Gamma/\Pi_\infty\f$; [2] 5-equation; [3] 6-equation; [4] 4-equation |
-| `jwl_mix_type`             | Integer | JWL mixture closure for the 5-equation model: [0] isobaric (default, verified against an exact Riemann reference); [1] Kuhl, [2] p-T equilibrium, [3] Rocflu blend (experimental) |
+| `jwl_mix_type`             | Integer | JWL mixture closure for the 5-equation model: [0] isobaric (default); [1] supplied Kuhl/Khasainov; [2] supplied exact p-T equilibrium; [3] Rocflu state-interpolated single-fluid closure |
 | `alt_soundspeed` *         | Logical | Alternate sound speed and \f$K \nabla \cdot u\f$ for 5-equation model |
 | `adv_n`   	               | Logical | Solving directly for the number density (in the method of classes) and compute void fraction from the number density |
 | `mpp_lim`	                 | Logical | Mixture physical parameters limits |

examples/1D_jwl_single_material_shocktube/case.py

@@ -62,6 +62,7 @@
             "fluid_pp(1)%jwl_air_e0": 2.5575e5,
             "fluid_pp(1)%jwl_air_rho0": 1.225,
             "fluid_pp(1)%jwl_air_gamma": 0.4,
+            "jwl_mix_type": 3,
         }
     )
 )

examples/2D_jwl_mixture_test/case.py

@@ -131,7 +131,9 @@
     "fluid_pp(2)%eos": 1,
     "fluid_pp(2)%gamma": 1.0 / 0.4,
     "fluid_pp(2)%pi_inf": 0.0,
+    "fluid_pp(2)%cv": 717.5,
     "fluid_pp(2)%Re(1)": 2.5e6,
+    "jwl_mix_type": 3,
 }
 
 particle_radius = 0.01

src/common/m_checker_common.fpp

@@ -12,7 +12,7 @@ module m_checker_common
     use m_mpi_proxy
     use m_helper_basic
     use m_helper
-    use m_constants, only: eos_stiffened_gas, eos_jwl, model_eqns_5eq, jwl_mix_type_ptequil
+    use m_constants, only: eos_stiffened_gas, eos_jwl, model_eqns_5eq, jwl_mix_type_rocflu
 
     implicit none
 
@@ -76,12 +76,18 @@ contains
         @:PROHIBIT(n_jwl > 1, "At most one fluid may use eos_jwl")
         @:PROHIBIT(jwl_fluid > 0 .and. model_eqns /= model_eqns_5eq, "JWL EOS is only supported with model_eqns_5eq")
 
-        if (jwl_fluid > 0 .and. jwl_mix_type == jwl_mix_type_ptequil) then
-            @:PROHIBIT(air_fluid == 0, "jwl_mix_type p-T equilibrium requires one non-JWL ideal-gas fluid")
-            @:PROHIBIT(f_is_default(fluid_pp(jwl_fluid)%cv) .or. fluid_pp(jwl_fluid)%cv <= 0._wp &
-                       & .or. f_is_default(fluid_pp(air_fluid)%cv) .or. fluid_pp(air_fluid)%cv <= 0._wp, &
-                       & "jwl_mix_type p-T equilibrium requires positive fluid_pp%cv for both the JWL " &
-                       & // "fluid and the ideal-gas fluid")
+        @:PROHIBIT(jwl_fluid > 0 .and. jwl_mix_type /= jwl_mix_type_rocflu, &
+                   & "Only jwl_mix_type = 3 (Rocflu) is supported; modes 0, 1, and 2 have been removed")
+
+        if (jwl_fluid > 0 .and. jwl_mix_type == jwl_mix_type_rocflu) then
+            @:PROHIBIT(num_fluids > 1 .and. air_fluid == 0, "Rocflu closure requires one non-JWL ideal-gas fluid")
+            @:PROHIBIT(f_is_default(fluid_pp(jwl_fluid)%cv) .or. fluid_pp(jwl_fluid)%cv <= 0._wp, &
+                       & "Rocflu closure requires positive fluid_pp%cv for the JWL fluid")
+            @:PROHIBIT(air_fluid > 0 .and. (f_is_default(fluid_pp(air_fluid)%cv) .or. fluid_pp(air_fluid)%cv <= 0._wp), &
+                       & "Rocflu closure requires positive fluid_pp%cv for the non-JWL air fluid")
+            @:PROHIBIT(fluid_pp(jwl_fluid)%jwl_rho0 <= fluid_pp(jwl_fluid)%jwl_air_rho0 &
+                       & .or. fluid_pp(jwl_fluid)%jwl_E0/fluid_pp(jwl_fluid)%jwl_rho0 <= fluid_pp(jwl_fluid)%jwl_air_e0, &
+                       & "Rocflu closure requires increasing air-to-products reference density and energy")
         end if
 
     end subroutine s_check_jwl_inputs