Skip to content

Commit c85f950

Browse files
committed
fix: loosen low_mach FP-stability threshold to 2e-7
The low_mach test exercises HLLC's low-Mach correction at near-zero Mach, where (u_R - u_L) is fundamentally small. Verrou MCA sampling variance puts the max_dev distribution typically around 5e-8 with a tail occasionally hitting ~1e-7, making the previous 1e-7 threshold flaky. Loosen to 2e-7 to absorb sampling noise. After #1408 (WENO5 sum-of-squares beta) merges, the WENO contribution to the cancellation chain disappears on uniform grids and the threshold can be tightened back.
1 parent ef20c51 commit c85f950

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

toolchain/mfc/fp_stability.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ def _get_source_context(fname: str, lineno: int, context: int = 2) -> str:
156156
"name": "low_mach",
157157
"description": "1-D water shock with low_Mach=1 HLLC correction active",
158158
"compare": ["cons.1.00.000050.dat", "prim.3.00.000050.dat"],
159-
"threshold": 1e-7,
160-
"ill_cond": "low_Mach correction: velocity perturbation ~u/c cancels severely at M≈0",
159+
"threshold": 2e-7,
160+
"ill_cond": "low_Mach correction: velocity perturbation ~u/c cancels severely at M≈0 (threshold loosened to 2e-7 to absorb MCA sampling variance)",
161161
},
162162
]
163163

0 commit comments

Comments
 (0)