Now that we are accurately computing the Ib markers, it is clean that the MFC Character test is actually quite ill-posed, as the model is constantly pointing inside of itself. Now that the other STL cases are corrected, it should probably be deprecated from the test suite until we undertand how those instabilities are handled

Author: danieljvickers

src/common/m_model.fpp

@@ -1032,16 +1032,14 @@ contains
                 norm(2) = boundary_v(i, 3, 2, pid)
             else if (t < 0._wp) then ! negative t means that v1 is the closest point on the edge
                 dist = sqrt((point(1) - v1(1))**2 + (point(2) - v1(2))**2)
-                norm(1) = point(1) - v1(1)
-                norm(2) = point(2) - v1(2)
-                norm_mag = sqrt(dot_product(norm, norm))
-                norm = norm/norm_mag
+                norm(1) = v1(1) - point(1)
+                norm(2) = v1(2) - point(2)
+                norm = norm/dist
             else ! t > 1 means that v2 is the closest point on the line edge
                 dist = sqrt((point(1) - v2(1))**2 + (point(2) - v2(2))**2)
-                norm(1) = point(1) - v2(1)
-                norm(2) = point(2) - v2(2)
-                norm_mag = sqrt(dot_product(norm, norm))
-                norm = norm/norm_mag
+                norm(1) = v2(1) - point(1)
+                norm(2) = v2(2) - point(2)
+                norm = norm/dist
             end if
 
             if (dist < dist_min) then

src/simulation/m_compute_levelset.fpp

@@ -33,7 +33,7 @@ contains
 
         integer :: i, patch_id, patch_geometry
 
-        print *, "num_gps: ", num_gps
+        print *, num_gps
 
         !  3D Patch Geometries
         if (p > 0) then
@@ -83,11 +83,6 @@ contains
 
         end if
 
-        $:GPU_UPDATE(host='[gps]')
-        do i = 1, num_gps
-            print *, gps(i)%loc, gps(i)%levelset, gps(i)%levelset_norm
-        end do
-
     end subroutine s_apply_levelset
 
     !> @brief Computes the signed distance and outward normal from a ghost point to a circular immersed boundary.

src/simulation/m_ib_patches.fpp

@@ -867,7 +867,7 @@ contains
                                              patch_id, xy_local)
 
                 ! Reading STL boundary vertices and compute the levelset and levelset_norm
-                if (eta > 0.5_wp) then
+                if (eta > threshold) then
                     ib_markers%sf(i, j, 0) = patch_id
                 end if
             end do
@@ -929,8 +929,7 @@ contains
                                                  gpu_trs_v, gpu_trs_n, &
                                                  patch_id, xyz_local)
 
-                    ! if (eta > patch_ib(patch_id)%model_threshold) then
-                    if (eta > 0.5_wp) then
+                    if (eta > patch_ib(patch_id)%model_threshold) then
                         ib_markers%sf(i, j, k) = patch_id
                     end if
                 end do
@@ -1103,8 +1102,6 @@ contains
             end if
         end block
 
-        print *, "Finished reading models"
-
     end subroutine s_instantiate_STL_models
 
     !> Subroutine that computes a rotation matrix for converting to the rotating frame of the boundary